Skip to content

Simplify check lang.mimetypes #42932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexdima merged 1 commit into from
Mar 26, 2018
Merged

Simplify check lang.mimetypes #42932

alexdima merged 1 commit into from
Mar 26, 2018

Conversation

@Connormiha
Copy link
Contributor

@Connormiha Connormiha commented Feb 4, 2018

This PR simplify mergeLanguage

  1. Remove needless check for type undefined, because Array.isArray doesn't pass undefined, null, etc.
  2. Get rid of for loop and use native push + spread
  3. Don't check primaryMime in each step. Just pull from first element.

@alexdima alexdima self-assigned this Feb 5, 2018
@alexdima alexdima added this to the March 2018 milestone Mar 26, 2018
@alexdima alexdima merged commit 5267caa into microsoft:master Mar 26, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@nunarokapp nunarokapp nunarokapp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@alexdima alexdima

Labels

None yet

Projects

None yet

Milestone

March 2018

Development

Successfully merging this pull request may close these issues.

3 participants

@Connormiha @nunarokapp @alexdima