Skip to content

fix persistent workbench UI performance degradation #324986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ben Villalobos (benvillalobos) merged 1 commit into from
Jul 11, 2026
Merged

fix persistent workbench UI performance degradation #324986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix persistent workbench UI performance degradation
  • Loading branch information
@Kaidesuyoo
Kaidesuyoo committed Jul 8, 2026
commit 4a8b207fc2dbfc1b40d0a9860a0b40c2bd5b35af
8 changes: 6 additions & 2 deletions src/vs/sessions/contrib/automations/browser/automationDialogService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import * as DOM from '../../../../base/browser/dom.js';
import { IButton } from '../../../../base/browser/ui/button/button.js';
import { Dialog } from '../../../../base/browser/ui/dialog/dialog.js';
import { DisposableStore } from '../../../../base/common/lifecycle.js';
import { DisposableStore, toDisposable } from '../../../../base/common/lifecycle.js';
import { localize } from '../../../../nls.js';
import { IConfigurationService } from '../../../../platform/configuration/common/configuration.js';
import { IContextKeyService } from '../../../../platform/contextkey/common/contextkey.js';
Expand Down Expand Up @@ -89,8 +89,9 @@ export class AutomationDialogService implements IAutomationDialogService {
localize('automation.dialog.cancel', "Cancel"),
];

const activeContainer = this.layoutService.activeContainer;
const dialog = disposables.add(new Dialog(
this.layoutService.activeContainer,
activeContainer,
title,
buttonLabels,
createWorkbenchDialogOptions({
Expand Down Expand Up @@ -133,6 +134,9 @@ export class AutomationDialogService implements IAutomationDialogService {
}, this.keybindingService, this.layoutService, this.hostService),
));

activeContainer.classList.add('automation-dialog-open');
disposables.add(toDisposable(() => activeContainer.classList.remove('automation-dialog-open')));

try {
const result = await dialog.show();
if (result.button !== 0) {
Expand Down
14 changes: 6 additions & 8 deletions src/vs/workbench/contrib/chat/browser/aiCustomization/media/aiCustomizationManagement.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2348,20 +2348,18 @@ pane is first mounted. View switches inside the modal are not animated. */
* contextview.ts as `2575 + layer`). DOM order means the dialog
* shows on top, hiding any popup the chat input chips, the quick
* input, or a context menu try to open. We can't change the inline
* z-index from outside, so use `!important` on rules scoped to
* `body:has(.automation-dialog)`. They only apply while the
* automations dialog is on screen, so other dialogs' popup stacking
* is untouched.
* z-index from outside, so use `!important` while the dialog service
* marks the active container as automation-dialog-open.
*/
body:has(.automation-dialog) .context-view.monaco-component {
.automation-dialog-open .context-view.monaco-component {
z-index: 2600 !important;
}

body:has(.automation-dialog) .quick-input-widget {
.automation-dialog-open .quick-input-widget {
z-index: 2600 !important;
}

body:has(.automation-dialog) .monaco-menu-container {
.automation-dialog-open .monaco-menu-container {
z-index: 2600 !important;
}

Expand Down Expand Up @@ -2858,4 +2856,4 @@ body:has(.automation-dialog) .monaco-menu-container {
overflow: hidden;
text-overflow: ellipsis;
max-width: 240px;
}
}
Loading