Add shellscript filenamePatterns for .env.* - #173426
Merged
Merged
Conversation
In some cases, projects use `.env` files such as `.env.development` or `.env.production` or similar things. Adding this to extensions/shellscript/package.json as a `filenamePatterns` avoids developers having to add specific `"files.associations"` to their VS Code settings files. Fixes #173425
Member
|
Tobias Hernstig (@thernstig) can you share several examples of these |
Contributor
Author
Alex Ross (alexr00)
left a comment
Member
There was a problem hiding this comment.
Thank you for the details. Just one more question.
filenamePatterns for .env*filenamePatterns for .env.*
Alex Ross (alexr00)
approved these changes
Feb 10, 2023
Alex Ross (alexr00)
left a comment
Member
There was a problem hiding this comment.
Thank you for the change!
Alex Ross (alexr00)
enabled auto-merge (squash)
February 10, 2023 14:10
João Moreno (joaomoreno)
approved these changes
Feb 10, 2023
Cristopher Claeys (c-claeys)
pushed a commit
to c-claeys/vscode
that referenced
this pull request
Feb 16, 2023
* Add shellscript `filenamePatterns` for `.env*` In some cases, projects use `.env` files such as `.env.development` or `.env.production` or similar things. Adding this to extensions/shellscript/package.json as a `filenamePatterns` avoids developers having to add specific `"files.associations"` to their VS Code settings files. Fixes microsoft#173425 * Change pattern from .env* to .env.*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases, projects use
.envfiles such as.env.developmentor.env.productionor similar things.Adding this to extensions/shellscript/package.json as a
filenamePatternsavoids developers having to add specific"files.associations"to their VS Code settings files.Fixes #173425