Support shell integration in Windows PowerShell - #167023
Merged
Daniel Imms (Tyriar) merged 1 commit intoNov 23, 2022
Merged
Conversation
By replacing `e with $([char]0x1b), we allow shell integration to work with Windows PowerShell, as the only problem seemed to be use of `e, which was an escape character added only to PowerShell Core, but the `[char]` equivalent works fine.
Andy Jordan (andyleejordan)
force-pushed
the
andschwa/escape-char
branch
from
November 23, 2022 01:06
2da75e9 to
dc67523
Compare
Daniel Imms (Tyriar)
approved these changes
Nov 23, 2022
Daniel Imms (Tyriar)
left a comment
Contributor
There was a problem hiding this comment.
This is awesome 👏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By replacing backtick-e with
$([char]0x1b), we allow shell integration to work with Windows PowerShell, as the only problem seemed to be use of backtick-e, which was an escape character added only to PowerShell Core, but the[char]equivalent works fine.I built and tested this on Windows and it sure seems fine!
/cc Daniel Imms (@Tyriar)