Fix comma splices in descriptions in src/vs/workbench/contrib/terminal/common/terminalConfiguration.ts - #164401
Merged
Daniel Imms (Tyriar) merged 9 commits intoOct 24, 2022
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
Megan Rogge (meganrogge)
previously approved these changes
Oct 24, 2022
Daniel Imms (Tyriar)
previously approved these changes
Oct 24, 2022
Daniel Imms (Tyriar)
left a comment
Contributor
There was a problem hiding this comment.
TIL I often use comma splices 👀
Daniel Imms (Tyriar)
enabled auto-merge
October 24, 2022 19:49
auto-merge was automatically disabled
October 24, 2022 20:29
Head branch was pushed to by a user without write access
Hugh Lilly (hughlilly)
dismissed stale reviews from Daniel Imms (Tyriar) and Megan Rogge (meganrogge)
via
October 24, 2022 20:29
c22980c
Contributor
Author
|
Sorry, I think I might have made a mistake here; I was trying to add another commit. |
Megan Rogge (meganrogge)
approved these changes
Oct 24, 2022
Daniel Imms (Tyriar)
approved these changes
Oct 24, 2022
formigoni
pushed a commit
to formigoni/vscode
that referenced
this pull request
Oct 27, 2022
Fix comma splices in descriptions in `src/vs/workbench/contrib/terminal/common/terminalConfiguration.ts`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR suggests a number of grammatical fixes in
src/vs/workbench/contrib/terminal/common/terminalConfiguration.ts, mostly to remedy comma splices.