Skip to content

Fix tab position when wrapping tabs - #156116

Merged
Benjamin Pasero (bpasero) merged 1 commit into
microsoft:mainfrom
pingren:fix/tab-wrap-position
Jul 25, 2022
Merged

Fix tab position when wrapping tabs#156116
Benjamin Pasero (bpasero) merged 1 commit into
microsoft:mainfrom
pingren:fix/tab-wrap-position

Conversation

@pingren

Copy link
Copy Markdown
Contributor

Fixes #154432

Explanation

Sticky tabs need a style.left with a px to remain at their location.
If setting workbench.editor.wrapTabs: true, it is not needed any more.
Setting a style.left with wrong px will cause the issue in #154432.

Before:

Code-OSS-25Jul22_15-05-12.mp4

After:

Code-OSS-25Jul22_15-07-17.mp4

@bpasero Benjamin Pasero (bpasero) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! I love open source ❤️

@bpasero
Benjamin Pasero (bpasero) merged commit e7a5e2f into microsoft:main Jul 25, 2022
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tabs wrap: visual glitch with pinned tabs and shrink sizing

2 participants