Replace the deprecated canceled with Cancellation Error. - #156094
Merged
Sandeep Somavarapu (sandy081) merged 2 commits intoJul 27, 2022
Conversation
Signed-off-by: Letu Ren <fantasquex@gmail.com>
Matt Bierner (mjbvz)
removed their request for review
July 25, 2022 14:12
Sandeep Somavarapu (sandy081)
self-requested a review
July 27, 2022 07:47
Sandeep Somavarapu (sandy081)
approved these changes
Jul 27, 2022
Alex Ross (alexr00)
approved these changes
Jul 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to
vscode/src/vs/base/common/errors.ts
Line 164 in 0bdda74
canceledis deprecated. So I replaced it with the recommendation.