Detect terminal links with space, then line:col

[Stephen Sigwart (ssigwart)]

This PR fixes #140780

To test, you can open a terminal and run echo ./myFile.txt 10:5 (replacing the filename with one that exists). When you click to open the file, it should open to line 10, column 5.

[Daniel Imms (Tyriar)]

Thanks! I added a test to make sure we don't break it 🙂

[Stephen Sigwart (ssigwart)]

Thanks for adding the test, Daniel Imms (@Tyriar).

[galenbwill]

This commit seems to break links of the form:
(file path):45
and
(file path):45:13
It prevents them from navigating to the line (and column).

[Daniel Imms (Tyriar)]

galenbwill you might be seeing #155065 which isn't out in insiders yet?

[YuTengjing (tjx666)]

For path like './web/pages/home/componentPanel.tsx:55:9'
can't go to the right line and column, but can go to file.

Daniel Imms (@Tyriar) still an issue in latest insider.

Version: 1.70.0-insider (Universal)
Commit: 1cd90cceddf3c413673963ab6f154d2ff294b17c
Date: 2022-07-15T05:17:24.241Z
Electron: 18.3.5
Chromium: 100.0.4896.160
Node.js: 16.13.2
V8: 10.0.139.17-electron.0
OS: Darwin x64 21.5.0

[Daniel Imms (Tyriar)]

YuTengjing (@tjx666) both ./web/pages/home/componentPanel.tsx:55:9 and web/pages/home/componentPanel.tsx:55:9 formats are working for me on macOS, both with and without shell integration enabled. If you can still repro could you open a new issue with a more detailed report?

[galenbwill]

I can confirm that (file path):55:9 and (file path):55 are now working for me on latest insiders 1.70.0 on macOS:

Version: 1.70.0-insider
Commit: 1cd90cceddf3c413673963ab6f154d2ff294b17c
Date: 2022-07-15T05:32:19.076Z (3 days ago)
Electron: 18.3.5
Chromium: 100.0.4896.160
Node.js: 16.13.2
V8: 10.0.139.17-electron.0
OS: Darwin arm64 21.5.0

[YuTengjing (tjx666)]

Daniel Imms (@Tyriar) #155532