Replace languageId by languageSelector in all language feature registration functions - #143610
Merged
Alexandru Dima (alexdima) merged 1 commit intoFeb 22, 2022
Conversation
|
|
Member
|
This change has no runtime implications, it just affects typing and parameter names. The suggested change looks reasonable. |
Member
|
Thank you! |
Contributor
Author
|
btw, shouldn't it appear in the monaco-editor 0.33 changelog? |
Member
|
Sorry, we missed that! Unfortunately we cannot update 0.33.0 on NPM anymore. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It allows to register a language provider on more than one language at once.
This PR fixes microsoft/monaco-editor#2985