Skip to content

Add optional languageId to window.createOutputChannel API (#19561) - #140876

Merged
Sandeep Somavarapu (sandy081) merged 4 commits into
microsoft:mainfrom
gjsjohnmurray:output-channel-language
Feb 9, 2022
Merged

Add optional languageId to window.createOutputChannel API (#19561)#140876
Sandeep Somavarapu (sandy081) merged 4 commits into
microsoft:mainfrom
gjsjohnmurray:output-channel-language

Conversation

@gjsjohnmurray

Copy link
Copy Markdown
Contributor

This PR fixes #19561 by implementing proposed API which adds an optional languageId param to window.createOutputChannel.

This was previously suggested by Artem Govorov (@ArtemGovorov) and was supported at the time by Johannes Rieken (@jrieken).

It was later raised as a solution for #19561, opened by Jun Han (@formulahendry).

Comment thread src/vs/workbench/api/common/extHostOutput.ts Outdated
Comment thread src/vs/workbench/api/common/extHost.api.impl.ts
@gjsjohnmurray

Copy link
Copy Markdown
Contributor Author

Sandeep Somavarapu (@sandy081) any chance you could consider merging this in time for Monday's endgame?

@sandy081

Copy link
Copy Markdown
Member

I am sorry that I have to postpone this for the next milestone as this has to be discussed in our API sync meeting first. The last API sync for this milestone finished today and unfortunately I missed checking this in time. Since there is no urgency, I will plan this for next milestone and discuss in our API sync.

@gjsjohnmurray

Copy link
Copy Markdown
Contributor Author

Sandeep Somavarapu (@sandy081) no worries. I know you have been busy with other things.

@gjsjohnmurray

Copy link
Copy Markdown
Contributor Author

Sandeep Somavarapu (@sandy081) now that 1.64 has shipped, when will the next API sync meeting happen? I'd like to get this into Insiders soon.

@sandy081

Copy link
Copy Markdown
Member

John Murray (@gjsjohnmurray) Thanks for reminding. API call is today. As per the process we will first add it to the proposed API and after getting some feedback we will finalize it. So most probably this will be a proposed API in this month and goes into finalization next month.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Did some small clean ups. Approved.

@sandy081
Sandeep Somavarapu (sandy081) merged commit 4af4717 into microsoft:main Feb 9, 2022
@gjsjohnmurray
John Murray (gjsjohnmurray) deleted the output-channel-language branch February 9, 2022 15:45
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow to provide colorizers for specific output channels

5 participants