Skip to content

Add cuda-cpp lang id, grammar and problem matchers#119444

Merged
alexr00 merged 14 commits intomicrosoft:mainfrom
PooyaZv:nvidia/the-combined-3-cuda-cpp-changes
Mar 30, 2021
Merged

Add cuda-cpp lang id, grammar and problem matchers#119444
alexr00 merged 14 commits intomicrosoft:mainfrom
PooyaZv:nvidia/the-combined-3-cuda-cpp-changes

Conversation

@PooyaZv
Copy link
Contributor

@PooyaZv PooyaZv commented Mar 22, 2021

This PR:

  • adds a language ID for cuda-cpp
  • adds a (TextMate) grammar for cuda-cpp
  • adds a problem matcher for cuda-cpp (based on the output of the nvcc compiler)

@ghost
Copy link

ghost commented Mar 22, 2021

CLA assistant check
All CLA requirements met.

@PooyaZv
Copy link
Contributor Author

PooyaZv commented Mar 22, 2021

@alexr00 This PR is our 3 cuda-cpp PRs combined if it is preferred.

Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in package.json all look good. The only changes needed are to add a test file and to make sure the new grammar is included in our scripts.

@alexr00
Copy link
Member

alexr00 commented Mar 22, 2021

@PooyaZv don't forget to also sign the contributor license agreement (#119444 (comment)).

@alexr00 alexr00 added this to the April 2021 milestone Mar 23, 2021
@PooyaZv
Copy link
Contributor Author

PooyaZv commented Mar 24, 2021

@alexr00 I have added the update to update-grammars.js and tested the PR with the latest changes. It's all locked, loaded and ready for merging 😊 Thank you very much for all your help.

@alexr00
Copy link
Member

alexr00 commented Mar 25, 2021

👍 good stuff @PooyaZv. We're getting ready to release soon, which means the only changes that should be merged are bugfixes. Once we branch for release and reopen main for feature work I'll take one last look and merge (probably on Monday).

@PooyaZv
Copy link
Contributor Author

PooyaZv commented Mar 28, 2021

Thank you very much 😊

@alexr00 alexr00 merged commit 95420b3 into microsoft:main Mar 30, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants