Skip to content

Fix file location pattern in eslint-stylish problem matcher#117576

Merged
alexr00 merged 1 commit intomicrosoft:mainfrom
sokolovstas:stas/113306
Apr 26, 2021
Merged

Fix file location pattern in eslint-stylish problem matcher#117576
alexr00 merged 1 commit intomicrosoft:mainfrom
sokolovstas:stas/113306

Conversation

@sokolovstas
Copy link
Contributor

eslint-stylish file location pattern now match relative and absolute path in Window and *nix

This PR fixes #113306

@alexr00 alexr00 added this to the April 2021 milestone Apr 21, 2021
@alexr00
Copy link
Member

alexr00 commented Apr 21, 2021

@sokolovstas sorry for the lack of attention on this PR, it slipped past me. Can you provide two full sets of sample output that you expect to work with this problem matcher: one that has always worked with this problem matcher and one that didn't used to work, but will work with your changes?

@yrtimiD
Copy link

yrtimiD commented Apr 21, 2021

I can provide this, if you don't mind

  • always worked
/home/bla/bla/src/code.ts
   24:1   error  Unexpected var, use let or const instead                                                                                                                                                                                                                                                                                                                                                                            no-var
  • was broken, should work now
/home/bla/bla/src/code.ts
  389:79  error  Don't use `Function` as a type. The `Function` type accepts any function-like value.
It provides no type safety when calling the function, which can be a common source of bugs.
It also accepts things like class declarations, which will throw at runtime as they will not be called with `new`.
If you are expecting the function to accept certain arguments, you should explicitly define the function shape  @typescript-eslint/ban-types

Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, thank you!

@alexr00 alexr00 merged commit 205a366 into microsoft:main Apr 26, 2021
gjsjohnmurray pushed a commit to gjsjohnmurray/vscode that referenced this pull request Apr 26, 2021
…t#117576)

eslint-stylish file location pattern now match relative and absolute path in Window and *nix

This PR fixes microsoft#113306
@github-actions github-actions bot locked and limited conversation to collaborators Jun 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

eslint-stylish problem matcher fails on multi-line rule messages

3 participants