Fix file location pattern in eslint-stylish problem matcher#117576
Merged
alexr00 merged 1 commit intomicrosoft:mainfrom Apr 26, 2021
Merged
Fix file location pattern in eslint-stylish problem matcher#117576alexr00 merged 1 commit intomicrosoft:mainfrom
alexr00 merged 1 commit intomicrosoft:mainfrom
Conversation
Member
|
@sokolovstas sorry for the lack of attention on this PR, it slipped past me. Can you provide two full sets of sample output that you expect to work with this problem matcher: one that has always worked with this problem matcher and one that didn't used to work, but will work with your changes? |
|
I can provide this, if you don't mind
|
alexr00
approved these changes
Apr 26, 2021
Member
alexr00
left a comment
There was a problem hiding this comment.
Change looks good, thank you!
gjsjohnmurray
pushed a commit
to gjsjohnmurray/vscode
that referenced
this pull request
Apr 26, 2021
…t#117576) eslint-stylish file location pattern now match relative and absolute path in Window and *nix This PR fixes microsoft#113306
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eslint-stylish file location pattern now match relative and absolute path in Window and *nix
This PR fixes #113306