Skip to content

Support greater than and less than - #110846

Merged
Alexandru Dima (alexdima) merged 5 commits into
microsoft:masterfrom
Wscats:patch-3
Dec 2, 2020
Merged

Support greater than and less than#110846
Alexandru Dima (alexdima) merged 5 commits into
microsoft:masterfrom
Wscats:patch-3

Conversation

@Wscats

Copy link
Copy Markdown
Contributor

Hope contextkey.ts supports greater than and less than, to facilitate the extension of features.

@ghost

Deleted user (ghost) commented Nov 18, 2020

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@roblourens

Copy link
Copy Markdown
Member

Is there an issue for this feature?

@Wscats

enoyao (Wscats) commented Nov 18, 2020

Copy link
Copy Markdown
Contributor Author

Is there an issue for this feature?

With a small change here, a more precise and simple comparison can be made, Can be used for comparison, such as gitOpenRepositoryCount > 0, workspaceFolderCount > 2, editor.cursorSurroundingLines/editor.fontSize/editor.lineHeight and the extension can be more flexible.

"menus": {
      "commandPalette": [
        {
          "command": "git.close",
          "when": "gitOpenRepositoryCount > 0"
        },
        {
          "command": "git.refresh",
          "when": "gitOpenRepositoryCount > 0"
        },
}

"viewsWelcome": [
      {
        "view": "scm",
        "contents": "%view.workbench.scm.workspace%",
        "when": "workspaceFolderCount > 2"
      },
]

@alexdima
Alexandru Dima (alexdima) merged commit 980ef5c into microsoft:master Dec 2, 2020
@alexdima

Copy link
Copy Markdown
Member

Thank you!

1 similar comment
@Wscats

enoyao (Wscats) commented Dec 2, 2020

Copy link
Copy Markdown
Contributor Author

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants