Skip to content

Fixing ListWidget escape button behavior #110760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
João Moreno (joaomoreno) merged 2 commits into from
Nov 25, 2020
Merged

Fixing ListWidget escape button behavior #110760

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
657e333
Merge pull request #1 from microsoft/master
aasimkhan30 Nov 16, 2020
5a1b424
Fixing how escape key works in listWidget
aasimkhan30 Nov 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fixing how escape key works in listWidget
  • Loading branch information
@aasimkhan30
aasimkhan30 committed Nov 16, 2020
commit 5a1b424614c5ac1b7b7676ff4d3c268aeb96814d
10 changes: 6 additions & 4 deletions src/vs/base/browser/ui/list/listWidget.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,10 +318,12 @@ class KeyboardController<T> implements IDisposable {
}

private onEscape(e: StandardKeyboardEvent): void {
e.preventDefault();
e.stopPropagation();
this.list.setSelection([], e.browserEvent);
this.view.domNode.focus();
if (this.list.getSelection().length) {
e.preventDefault();
e.stopPropagation();
this.list.setSelection([], e.browserEvent);
this.view.domNode.focus();
}
}

dispose() {
Expand Down