Skip to content

Including ` as part of foldEndPairCharacters - #110108

Merged
Matt Bierner (mjbvz) merged 2 commits into
microsoft:masterfrom
sumanbk92:master
Nov 10, 2020
Merged

Including ` as part of foldEndPairCharacters#110108
Matt Bierner (mjbvz) merged 2 commits into
microsoft:masterfrom
sumanbk92:master

Conversation

@sumanbk92

@sumanbk92 Suman B K (sumanbk92) commented Nov 6, 2020

Copy link
Copy Markdown
Contributor

This PR fixes folding lines incase of backticks (`)

@rheh Ray Hammond (rheh) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should a new test be added to folding.test.ts?

@sumanbk92 Suman B K (sumanbk92) changed the title Including '`' as part of foldEndPairCharacters Including ` as part of foldEndPairCharacters Nov 6, 2020
@sumanbk92

Copy link
Copy Markdown
Contributor Author

Should a new test be added to folding.test.ts?

Could you let me know how to run the folding.test.ts test file alone ?

@rheh

Copy link
Copy Markdown

Should a new test be added to folding.test.ts?

Could you let me know how to run the folding.test.ts test file alone ?

I think this should help https://github.com/microsoft/vscode/blob/master/test/unit/README.md

@sumanbk92 Suman B K (sumanbk92) left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added Tests and folding.test.ts was not found under extensions/typescript-language-features/src/test.
Hence added appropriate test under extensions/html-language-features/server/src/test/folding.test.ts

@sumanbk92 Suman B K (sumanbk92) changed the title Including ` as part of foldEndPairCharacters https://github.com/microsoft/vscode/issues/110097 Including ` as part of foldEndPairCharacters Nov 6, 2020
@sumanbk92 Suman B K (sumanbk92) changed the title https://github.com/microsoft/vscode/issues/110097 Including ` as part of foldEndPairCharacters Including ` as part of foldEndPairCharacters Nov 6, 2020

@sumanbk92 Suman B K (sumanbk92) left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aeschli

Copy link
Copy Markdown
Contributor

The test extensions/html-language-features/server/src/test/folding.test.ts is not related to the code change in extensions/html-language-features/server/src/test/folding.test.ts. I suggest to remove the test.

@sumanbk92

Copy link
Copy Markdown
Contributor Author

Removed unnecessary test.
Please review, Matt Bierner (@mjbvz)

@mjbvz

Copy link
Copy Markdown
Contributor

Please create an issue the describe the problem this PR fixes. We need this for tracking what we fix each iteration

@mjbvz Matt Bierner (mjbvz) added this to the November 2020 milestone Nov 9, 2020
@sumanbk92

Copy link
Copy Markdown
Contributor Author

Please create an issue the describe the problem this PR fixes. We need this for tracking what we fix each iteration

The issue was created already. It is being tagged/referenced above in this PR.

Link: #110097

@mjbvz
Matt Bierner (mjbvz) merged commit 4247b29 into microsoft:master Nov 10, 2020
@mjbvz

Copy link
Copy Markdown
Contributor

Thanks. Will be in the next VS Code insiders build

In the future, make sure include the issue number in the PR issue description (or the commit message using fixes #110097 so that merging the PR closes the issue too)

@github-actions github-actions Bot locked and limited conversation to collaborators Dec 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants