feat: Autodetect npm.packageManager #102050 by shivangg · Pull Request #102494 · microsoft/vscode

Shivang Tripathi (shivangg) · 2020-07-14T13:36:38Z

This PR fixes #102050

npm.packageManager should have auto option and default to it.
When auto, check lock file to find preferred package manager.
Warn if auto set and multiple lock files found.

Deleted user (ghost) · 2020-07-14T13:36:51Z

All CLA requirements met.

Shivang Tripathi (shivangg) · 2020-08-10T16:03:04Z

Hey Alex Ross (@alexr00) One of the check is waiting to be reported. Can you help me understand the reason for that.

Also, is this blocking the PR review?

Shivang Tripathi (shivangg) · 2020-08-20T16:02:43Z

Alex Ross (@alexr00) Could you please advise an update on this PR?

Nicky McCurdy (nickserv) · 2020-08-30T16:13:14Z

Looks like there's a merge conflict in tasks.ts

Using default import for minimatch to resolve `esModuleInterop` conflict

Detects the preferred package manager and if multiple are present, warns and uses in priority order: npm => yarn => pnpm

Shivang Tripathi (shivangg) · 2020-08-30T21:26:10Z

@nickmccurdy Alex Ross (@alexr00) Resolved the merge conflict.

Shivang Tripathi (shivangg) · 2020-09-24T11:27:57Z

Alex Ross (@alexr00) Is something pending on this PR? I'd love to resolve it.

Alex Ross (alexr00) · 2020-09-24T15:05:09Z

Shivang Tripathi (@shivangg) thanks for your patience! I made a some changes to be consistent with the rest of the codebase and for some cleanup. I also have two changes requested from you.

Alex Ross (alexr00)

I addressed the last changes I wanted so that this can be merged.

Connor Peet (connor4312) · 2020-10-20T18:55:09Z

Alex Ross (@alexr00) with this do you think it's reasonable to expose a command for extensions to get the package manager? Previously in js-debug I was using the value of the setting, but this no longer works and the 'auto' resolution is not trivial enough I would want to copy-paste it into js-debug.

Alex Ross (alexr00) · 2020-10-21T08:33:34Z

Connor Peet (@connor4312) exposing a command to get the package manager seems perfectly reasonable. #109071

This reverts commit f8c0e3b.

Alex Ross (alexr00) · 2020-10-27T09:12:04Z

Reverted, we decided not to take on the additional dependencies.

Nicky McCurdy (nickserv) · 2020-10-27T14:28:58Z

Will this feature still be implemented or are you looking for another implementation with less dependencies?

Alex Ross (alexr00) · 2020-10-27T15:11:47Z

We have no plans to implement it in any specific time frame, but since it's on the backlog we still want to implement it eventually. You can see our roadmap for the kinds of things we're planning on working on.

Nicky McCurdy (nickserv) · 2020-10-27T16:05:04Z

In that case, would it be helpful if I recreated this pull request with fewer/no dependencies? I wanted to try it earlier but I'm new to VSCode development, though I think having this as a reference would help me.

Detects the preferred package manager and if multiple are present, warns and uses in priority order: npm => yarn => pnpm Fixes #102050 Co-authored-by: Alex Ross <alros@microsoft.com>

Alex Ross (alexr00) · 2020-11-02T13:49:13Z

I have re-merged this PR with bea7673

Alex Ross (alexr00) self-assigned this Jul 14, 2020

Shivang Tripathi (shivangg) force-pushed the shivangg/feat-npm-auto branch 2 times, most recently from 4370595 to beae5d1 Compare July 19, 2020 22:08

Alex Ross (alexr00) self-requested a review July 22, 2020 09:40

Shivang Tripathi (shivangg) marked this pull request as ready for review July 25, 2020 18:04

Shivang Tripathi (shivangg) force-pushed the shivangg/feat-npm-auto branch from 3bc8341 to fdbafbe Compare August 16, 2020 14:20

Nicky McCurdy (nickserv) approved these changes Aug 30, 2020

View reviewed changes

Nicky McCurdy (nickserv) mentioned this pull request Aug 30, 2020

Automatically detect package manager (npm.packageManager) #102050

Closed

Shivang Tripathi (shivangg) added 5 commits August 31, 2020 01:03

feat: Autodetect npm.packageManager microsoft#102050

0c2e1f2

use default import for minimatch

79571a9

Using default import for minimatch to resolve `esModuleInterop` conflict

find preferred pm with multiple pm detected flag

8e8a105

Detects the preferred package manager and if multiple are present, warns and uses in priority order: npm => yarn => pnpm

add localized warning when multiple PM detected

c196998

fix: Correct async iteration of scripts

8a3a76b

Shivang Tripathi (shivangg) force-pushed the shivangg/feat-npm-auto branch from fdbafbe to 8a3a76b Compare August 30, 2020 19:42

Nicky McCurdy (nickserv) approved these changes Aug 30, 2020

View reviewed changes

Alex Ross (alexr00) added this to the September 2020 milestone Aug 31, 2020

Merge branch 'master' into shivangg/feat-npm-auto

4ad394f

Alex Ross (alexr00) reviewed Sep 24, 2020

View reviewed changes

Comment thread extensions/npm/src/scriptHover.ts Outdated

Comment thread extensions/npm/yarn.lock

Comment thread extensions/npm/src/tasks.ts Outdated

Comment thread extensions/npm/src/tasks.ts Outdated

Some reveiw changes

9217824

Alex Ross (alexr00) modified the milestones: September 2020, October 2020 Sep 25, 2020

Alex Ross (alexr00) added 2 commits October 9, 2020 10:41

Merge branch 'master' into shivangg/feat-npm-auto

d98f246

Address review changes

49fde80

Alex Ross (alexr00) approved these changes Oct 9, 2020

View reviewed changes

Alex Ross (alexr00) merged commit f8c0e3b into microsoft:master Oct 9, 2020

Shivang Tripathi (shivangg) deleted the shivangg/feat-npm-auto branch October 9, 2020 12:10

Alex Ross (alexr00) mentioned this pull request Oct 21, 2020

Provide command to get package manager #109071

Closed

Jackson Kearl (JacksonKearl) mentioned this pull request Oct 27, 2020

Use find-yarn-workspace-root over find-yarn-workspace-root2 #109429

Merged

Alex Ross (alexr00) added a commit that referenced this pull request Oct 27, 2020

Revert "feat: Autodetect npm.packageManager #102050 (#102494)"

8d0ca78

This reverts commit f8c0e3b.

Alex Ross (alexr00) removed this from the October 2020 milestone Oct 27, 2020

Alex Ross (alexr00) added this to the November 2020 milestone Nov 2, 2020

github-actions Bot locked and limited conversation to collaborators Dec 4, 2020

Uh oh!

Conversation

Shivang Tripathi (shivangg) commented Jul 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Deleted user (ghost) commented Jul 14, 2020 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Shivang Tripathi (shivangg) commented Aug 10, 2020

Uh oh!

Shivang Tripathi (shivangg) commented Aug 20, 2020

Uh oh!

Nicky McCurdy (nickserv) commented Aug 30, 2020

Uh oh!

Shivang Tripathi (shivangg) commented Aug 30, 2020

Uh oh!

Shivang Tripathi (shivangg) commented Sep 24, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Alex Ross (alexr00) commented Sep 24, 2020

Uh oh!

Alex Ross (alexr00) left a comment

Choose a reason for hiding this comment

Uh oh!

Connor Peet (connor4312) commented Oct 20, 2020

Uh oh!

Alex Ross (alexr00) commented Oct 21, 2020

Uh oh!

Alex Ross (alexr00) commented Oct 27, 2020

Uh oh!

Nicky McCurdy (nickserv) commented Oct 27, 2020

Uh oh!

Alex Ross (alexr00) commented Oct 27, 2020

Uh oh!

Nicky McCurdy (nickserv) commented Oct 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Alex Ross (alexr00) commented Nov 2, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Shivang Tripathi (shivangg) commented Jul 14, 2020 •

edited

Loading

Deleted user (ghost) commented Jul 14, 2020 •

edited by ghost

Loading

Nicky McCurdy (nickserv) commented Oct 27, 2020 •

edited

Loading