feat: more descriptive error when childProcess.spawn fails - #888
Merged
Dirk Bäumer (dbaeumer) merged 2 commits intoFeb 4, 2022
Merged
Conversation
| return new Promise<MessageTransports>((_, reject) => { | ||
| process.on("error", (err) => { | ||
| reject(`${message} ${err}`); | ||
| }); |
Contributor
Author
There was a problem hiding this comment.
See https://nodejs.org/api/child_process.html#event-error
It's unfortunate that this is an event instead of it just being thrown from spawn.
David Sherret (dsherret)
marked this pull request as ready for review
February 2, 2022 21:24
Dirk Bäumer (dbaeumer)
requested changes
Feb 3, 2022
Dirk Bäumer (dbaeumer)
left a comment
Member
There was a problem hiding this comment.
Rest looks good to me. Thanks for providing this.
| } | ||
|
|
||
| return new Promise<MessageTransports>((_, reject) => { | ||
| process.on("error", (err) => { |
There was a problem hiding this comment.
One minor thing: we use single quotes for constant string values (e.g. 'error')
Contributor
Author
There was a problem hiding this comment.
Done!
Dirk Bäumer (dbaeumer)
approved these changes
Feb 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #887