Skip to content

Fix configuration not always using resource scope #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dirk Bäumer (dbaeumer) merged 1 commit into from
Jan 7, 2019
Merged

Fix configuration not always using resource scope #446

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix configuration not always using resource scope 
When requesting a nested configuration section (e.g. `a.b.c`), the configuration should still be using the `resource` scope, and act the same as when requesting a more global configuration section (e.g. `a`).
  • Loading branch information
@LaurentTreguier
LaurentTreguier committed Jan 2, 2019
commit 0f39851b45a210196c7de8545d4810c46be17a3b
2 changes: 1 addition & 1 deletion client/src/configuration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ export class ConfigurationFeature implements StaticFeature {
if (index === -1) {
result = workspace.getConfiguration(undefined, resource).get(section);
} else {
let config = workspace.getConfiguration(section.substr(0, index));
let config = workspace.getConfiguration(section.substr(0, index), resource);
if (config) {
result = config.get(section.substr(index + 1))
}
Expand Down