Double check if native tostring is [object *] - #1339
Merged
Connor Peet (connor4312) merged 2 commits intoJul 25, 2022
Merged
Conversation
Member
|
Thanks for the PR! Couple small comments |
Contributor
Author
|
Thank you very much for the comments, they totally make sense :) I've updated the PR! |
Connor Peet (connor4312)
approved these changes
Jul 25, 2022
Megan Rogge (meganrogge)
self-requested a review
July 25, 2022 15:44
Megan Rogge (meganrogge)
approved these changes
Jul 25, 2022
Leonardo Montini (Balastrong)
deleted the
feature/1338-double-check-object-string
branch
July 25, 2022 15:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #1338
As mentioned in the vscode repo (see microsoft/vscode#155718 (comment)) it might make sense to doublecheck and avoid using the native toString if the output is
[object *]and there is a better alternative.