[google-cloud-cpp] update to latest release (v2.13.0)

[Carlos O'Ryan (coryan)]

Updates google-cloud-cpp to the latest release (v2.13.0)

Tested locally (on x64-linux) with:

for feature in datafusion metastore migrationcenter networksecurity rapidmigrationassessment; do ./vcpkg remove google-cloud-cpp; ./vcpkg install "google-cloud-cpp[core,${feature}]" || break; done

and

./vcpkg remove google-cloud-cpp && ./vcpkg install 'google-cloud-cpp[*]'

• Changes comply with the maintainer guide
• SHA512s are updated for each updated download
• The "supports" clause reflects platforms that may be fixed by this new version
• Any fixed CI baseline entries are removed from that file.
• Any patches that are no longer applied are deleted from the port's directory.
• The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
• Only one version is added to each modified port's versions file.

[jim wang (jimwang118)]

I have the following issue when testing x64-windows.

F:\google-cloud-cpp\buildtrees\google-cloud-cpp\x64-windows-dbg\google\cloud\asset\google/cloud/asset/v1/assets.pb.h(4183): error C2059: syntax error: 'constant'
F:\google-cloud-cpp\buildtrees\google-cloud-cpp\x64-windows-dbg\google\cloud\asset\google/cloud/asset/v1/assets.pb.h(4184): error C2238: unexpected token(s) preceding ';'
F:\google-cloud-cpp\buildtrees\google-cloud-cpp\x64-windows-dbg\google\cloud\asset\google/cloud/asset/v1/assets.pb.h(4185): error C2059: syntax error: 'constant'
F:\google-cloud-cpp\buildtrees\google-cloud-cpp\x64-windows-dbg\google\cloud\asset\google/cloud/asset/v1/assets.pb.h(4186): error C2238: unexpected token(s) preceding ';'

[jim wang (jimwang118)]

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.

[Carlos O'Ryan (coryan)]

I have the following issue when testing x64-windows.

F:\google-cloud-cpp\buildtrees\google-cloud-cpp\x64-windows-dbg\google\cloud\asset\google/cloud/asset/v1/assets.pb.h(4183): error C2059: syntax error: 'constant'
F:\google-cloud-cpp\buildtrees\google-cloud-cpp\x64-windows-dbg\google\cloud\asset\google/cloud/asset/v1/assets.pb.h(4184): error C2238: unexpected token(s) preceding ';'
F:\google-cloud-cpp\buildtrees\google-cloud-cpp\x64-windows-dbg\google\cloud\asset\google/cloud/asset/v1/assets.pb.h(4185): error C2059: syntax error: 'constant'
F:\google-cloud-cpp\buildtrees\google-cloud-cpp\x64-windows-dbg\google\cloud\asset\google/cloud/asset/v1/assets.pb.h(4186): error C2238: unexpected token(s) preceding ';'

asset is already marked as not supported on Windows:

vcpkg/ports/google-cloud-cpp/vcpkg.json

Lines 137 to 151 in 228987a

	"asset": {
	"description": "Cloud Asset API C++ Client Library",
	"supports": "!windows",
	"dependencies": [
	{
	"name": "google-cloud-cpp",
	"default-features": false,
	"features": [
	"accesscontextmanager",
	"grpc-common",
	"osconfig"
	]
	}
	]
	},

This is not a new problem, the previous version would not compile on Windows either. Should I fix something with the feature annotations?

FWIW, the underlying problem is in Protobuf, and fixed in Protobuf >= 4.23.x (the generated code uses a symbol that is a macro on Windows). I am planning to mark the library as supported when vcpkg gets a recent enough version of Protobuf.

[jim wang (jimwang118)]

I have the following issue when testing x64-windows.

F:\google-cloud-cpp\buildtrees\google-cloud-cpp\x64-windows-dbg\google\cloud\asset\google/cloud/asset/v1/assets.pb.h(4183): error C2059: syntax error: 'constant'
F:\google-cloud-cpp\buildtrees\google-cloud-cpp\x64-windows-dbg\google\cloud\asset\google/cloud/asset/v1/assets.pb.h(4184): error C2238: unexpected token(s) preceding ';'
F:\google-cloud-cpp\buildtrees\google-cloud-cpp\x64-windows-dbg\google\cloud\asset\google/cloud/asset/v1/assets.pb.h(4185): error C2059: syntax error: 'constant'
F:\google-cloud-cpp\buildtrees\google-cloud-cpp\x64-windows-dbg\google\cloud\asset\google/cloud/asset/v1/assets.pb.h(4186): error C2238: unexpected token(s) preceding ';'

asset is already marked as not supported on Windows:

vcpkg/ports/google-cloud-cpp/vcpkg.json

Lines 137 to 151 in 228987a

	"asset": {
	"description": "Cloud Asset API C++ Client Library",
	"supports": "!windows",
	"dependencies": [
	{
	"name": "google-cloud-cpp",
	"default-features": false,
	"features": [
	"accesscontextmanager",
	"grpc-common",
	"osconfig"
	]
	}
	]
	},

This is not a new problem, the previous version would not compile on Windows either. Should I fix something with the feature annotations?

FWIW, the underlying problem is in Protobuf, and fixed in Protobuf >= 4.23.x (the generated code uses a symbol that is a macro on Windows). I am planning to mark the library as supported when vcpkg gets a recent enough version of Protobuf.

Ok, then I have no problem.