Merged
Conversation
Adds basic `cargo test` to CI. We'll want to run miri soon as well, but I'd like to do that as a separate step.
daprilik
approved these changes
Jul 21, 2022
Contributor
There was a problem hiding this comment.
LGTM.
Running clippy would be nice as well, but given the relative simplicity of the crate, I leave it up to you whether it's worth it. You'd also have to decide whether you'd want to pull in the clippy config from the old repo, or just stick with the out-of-box defaults.
Ahh, and rustfmt. Probably a good idea to include that in the CI as well.
Contributor
Author
|
Yeah, those tools sound good too. While I don't expect this crate to get big, it's easier to do that kind of infrastructure work early rather than doing it after the fact. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds basic
cargo testto CI.We'll want to run miri soon as well, but I'd like to do that as a separate step.