[eslint-plugin-packlets] Fix an incompatibility with TypeScript 4.2 #2603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iclanton
approved these changes
Apr 12, 2021
Collaborator
Author
|
This fix was released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
@rushstack/packlets/circular-depsrule did not work correctly with TypeScript 4.2Fixes #2591
Details
The reason is that the
DependencyAnalyzerrelies on an internal compiler API which was redesigned in TypeScript 4.2. See #2591 notes for details.How it was tested
@rushstack/packlets/circular-depsrule now correctly detects a circular reference with TypeScript 4.2.4@rushstack/packlets/circular-depsrule will works with TypeScript 3.9.9 that we used before