Skip to content

Add a direct reference to JSON schema#185

Merged
weinand merged 1 commit intomicrosoft:gh-pagesfrom
vadimcn:patch-2
Apr 13, 2021
Merged

Add a direct reference to JSON schema#185
weinand merged 1 commit intomicrosoft:gh-pagesfrom
vadimcn:patch-2

Conversation

@vadimcn
Copy link
Contributor

@vadimcn vadimcn commented Mar 31, 2021

Fixes #61

@vadimcn vadimcn changed the title Update specification.md Add a direct reference to JSON schema Apr 3, 2021
Copy link

@Takangcwele Takangcwele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tee

@Takangcwele Takangcwele mentioned this pull request Apr 4, 2021
Closed
@weinand weinand added this to the April 2021 milestone Apr 12, 2021
@weinand weinand self-assigned this Apr 12, 2021
@weinand weinand merged commit e006fb6 into microsoft:gh-pages Apr 13, 2021
@microsoft microsoft deleted a comment from Takangcwele Apr 13, 2021
@microsoft microsoft deleted a comment from Takangcwele Apr 13, 2021
@microsoft microsoft deleted a comment from Takangcwele Apr 13, 2021
@microsoft microsoft deleted a comment from Takangcwele Apr 13, 2021
@microsoft microsoft deleted a comment from Takangcwele Apr 13, 2021
@weinand
Copy link
Contributor

weinand commented Apr 13, 2021

@vadimcn after merging your PR, I've noticed (too late) that your fix lives in a machine generated file which gets overridden whenever the spec has changed:

2021-04-13_14-29-23

I've moved the change to the generator program instead.

weinand added a commit that referenced this pull request Apr 13, 2021
@vadimcn
Copy link
Contributor Author

vadimcn commented Apr 14, 2021

LOL. That line was loo long to read, obviously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants