Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output Config Option Values in Canonical Case #58735

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

graphemecluster
Copy link
Contributor

This aligns the letter cases of the values in tsconfig.jsons generated by tsc --init and some diagnostics (e.g. TS1501, TS6046) with the autocomplete values provided to tsconfig.json in VSCode and other diagnostics with hard-coded target versions.
This should not affect anything related to value parsing.

Addresses #55600 (comment).

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jun 2, 2024
@typescript-bot
Copy link
Collaborator

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

@jakebailey
Copy link
Member

For ecmascript versions I can sort of understand it, but I'm not totally convinced we consider "Node16" more canonical than "node16", "Preserve" etc, https://www.typescriptlang.org/tsconfig/#module

And so on.

@graphemecluster
Copy link
Contributor Author

I don’t know, I just completely sticked to the autocompletions provided by VSCode (except for a few subtle inconsistencies of lib values, which should be fixed in VSCode). So perhaps changes to the values should be made on the VSCode side synchronically.

@jakebailey
Copy link
Member

The autocompletions in VS Code are just the ones from schemastore. Not sure any of us like those either 😄

@graphemecluster
Copy link
Contributor Author

Oh, I see. Wonder why we didn’t maintain one here or in the VSCode repo.
Anyway, may you give me a list of what should be kept and what should be discarded once there is a consensus on the letter cases? Do you prefer camel case to Pascal case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants