Fixed crash in switch completions related to parenthesized expressions #52881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakebailey
approved these changes
Feb 21, 2023
src/services/stringCompletions.ts
Outdated
| case SyntaxKind.CaseClause: | ||
| const tracker = newCaseClauseTracker(typeChecker, (node.parent as CaseClause).parent.clauses); | ||
| const tracker = newCaseClauseTracker(typeChecker, (parent as CaseClause).parent.clauses); | ||
|
|
Member
There was a problem hiding this comment.
Nit: randomly added whitespace here.
Contributor
Author
There was a problem hiding this comment.
Eh, committing using github UI and their code suggestions can be risky… let’s try again, from mobile 😝
Member
There was a problem hiding this comment.
I find that github suggestions auto-add an extra newline sometimes which can cause this; it has to be manually deleted when making the suggestion.
Andarist
commented
Feb 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #52874