Remove shims project #50049
Merged
Remove shims project #50049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Let's roll it out in 4.9 and see what happens |
Member
Author
|
Tree is open for 4.9, so merging this as early as possible in the cycle so we can see if anyone breaks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The year is 2022; I would hope that these are defined by now in all of our supported platforms. I think it's already the case that we have required a newer
libanyway via #49623 usingcopyWithin, and nobody's complained yet.This removes the shims project and makes us throw if we can't find
MaporSet.It'd ultimately be nice to be able to just use the "real"
MapandSet, but this is a good step.