🤖 User test baselines have changed for refs/heads/master #36678
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a2f374b to
0ba5ea2
Compare
Closed
0ba5ea2 to
64452e8
Compare
Member
|
Very likely a result of #36665 |
sandersn
requested changes
Feb 11, 2020
Member
sandersn
left a comment
There was a problem hiding this comment.
Almost all the errors are from improved reporting on erroneous calls.
Good: more follow-on errors
Bad: errors on subsequent parameters are squelched, even those deep inside function expressions.
Ugly: I didn't investigate the office-ui-fabric errors.
| Type 'undefined' is not assignable to type 'number[]'. | ||
| node_modules/bcryptjs/src/bcrypt/impl.js(664,31): error TS2345: Argument of type 'null' is not assignable to parameter of type 'string | undefined'. | ||
| node_modules/bcryptjs/src/bcrypt/impl.js(666,26): error TS2345: Argument of type 'null' is not assignable to parameter of type 'Error'. | ||
| node_modules/bcryptjs/src/bcrypt/impl.js(666,39): error TS2345: Argument of type 'number[] | undefined' is not assignable to parameter of type 'number[]'. |
Member
There was a problem hiding this comment.
not sure why we now stop giving both errors on a call with two errors
| node_modules/bluebird/js/release/debuggability.js(258,48): error TS2345: Argument of type 'IArguments' is not assignable to parameter of type '["multipleResolves", MultipleResolveListener]'. | ||
| node_modules/bluebird/js/release/debuggability.js(301,56): error TS2345: Argument of type 'IArguments' is not assignable to parameter of type 'any[]'. | ||
| Type 'IArguments' is missing the following properties from type 'any[]': pop, push, concat, join, and 26 more. | ||
| node_modules/bluebird/js/release/debuggability.js(301,9): error TS2322: Type 'Process' is not assignable to type 'boolean'. |
Member
There was a problem hiding this comment.
this new error is much better.
| node_modules/lodash/_createHybrid.js(65,31): error TS2532: Object is possibly 'undefined'. | ||
| node_modules/lodash/_createHybrid.js(68,9): error TS2345: Argument of type 'TimerHandler' is not assignable to parameter of type 'Function'. | ||
| Type 'string' is not assignable to type 'Function'. | ||
| node_modules/lodash/_createHybrid.js(68,46): error TS2339: Property 'placeholder' does not exist on type '(...args: any[]) => any'. |
Member
There was a problem hiding this comment.
same -- subsequent errors are not reported
| Type 'T' is not assignable to type 'symbol'. | ||
| Type 'string | number | symbol' is not assignable to type 'symbol'. | ||
| Type 'string' is not assignable to type 'symbol'. | ||
| lib/Page.js(94,42): error TS2345: Argument of type 'Worker' is not assignable to parameter of type 'Worker'. |
Member
There was a problem hiding this comment.
from an update in puppeteer. (this error is from a bug, but it's a known bug)
| node_modules/npm/lib/install.js(985,53): error TS2339: Property 'config' does not exist on type 'typeof EventEmitter'. | ||
| node_modules/npm/lib/install.js(1007,53): error TS2339: Property 'config' does not exist on type 'typeof EventEmitter'. | ||
| node_modules/npm/lib/install/access-error.js(4,60): error TS2554: Expected 0-1 arguments, but got 2. | ||
| node_modules/npm/lib/install/access-error.js(5,12): error TS2339: Property 'code' does not exist on type 'Error'. |
Member
There was a problem hiding this comment.
I'm not sure why we didn't issue an error here before. It might be because of the erroneous call on the previous line, but the type is reported as Error, not any.
| node_modules/uglify-js/lib/compress.js(3276,42): error TS2554: Expected 0 arguments, but got 1. | ||
| node_modules/uglify-js/lib/compress.js(3355,33): error TS2532: Object is possibly 'undefined'. | ||
| node_modules/uglify-js/lib/compress.js(3762,38): error TS2554: Expected 0 arguments, but got 1. | ||
| node_modules/uglify-js/lib/compress.js(3788,29): error TS2322: Type '"f"' is not assignable to type 'boolean'. |
Member
There was a problem hiding this comment.
errors inside the function expression are squelched because the signature didn't expect arguments. this seems bad.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test run was triggerd by a request on #33716
Please review the diff and merge if no changes are unexpected.
You can view the build log here.
cc @microsoft/typescript