Skip to content

Fix qs Dependabot alerts through Express 4 update - #529

Open
robgruen wants to merge 1 commit into
mainfrom
fix/dependabot-qs
Open

robgruen wants to merge 1 commit into
mainfrom
fix/dependabot-qs

Conversation

@robgruen

Copy link
Copy Markdown
Contributor

Summary

  • Raise the music example's Express dependency to ^4.22.3, retaining Express 4 compatibility.
  • Regenerate the workspace lockfile to resolve qs to 6.16.2 and remove its redundant nested copy. No overrides or unrelated dependency updates.
  • Addresses all three currently open Dependabot alerts: 149, 150, and 200. Alerts will be reevaluated after merge.

Validation

Using the repository-pinned Node.js 24.22.1:

  • npm ci --prefer-offline --no-audit --no-fund — passed; the prepare hook also ran npm run build-all for the library and every example.
  • npm test — 372 passed, 0 failed or skipped.
  • npm audit --package-lock-only --audit-level=low — 0 vulnerabilities (passed on retry after an initial feed rate limit).
  • Offline smoke test of the actual music authorization callback and token routes — HTML response, query decoding, token delivery, and server shutdown passed without model or Spotify credentials.
  • Verified every locked qs instance meets all three alerts' patched-version thresholds, and only the music, Express, and qs lockfile entries changed.
  • git diff --check — passed.

Upgrade the music example to Express 4.22.3 and resolve qs 6.16.2 without overrides or unrelated dependency updates.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 12, 2026 04:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Custom Azure Artifacts URLs in typescript/package-lock.json break clean installs where that feed is blocked and need to be restored to canonical npm registry URLs.

1 open issue
1 file not reviewed
  • typescript/package-lock.json: Generated file
What changed in this PR

Updates the music example’s Express dependency to address the reported qs security alerts while retaining Express 4 compatibility.

Changes:

  • Raises the Express dependency range to ^4.22.3.
  • Updates the workspace lockfile to Express 4.22.3 and qs 6.16.2, removing the redundant nested qs copy.
File Description
typescript/​package-lock.json Updates Express and qs resolutions and removes duplicate qs.
typescript/​examples/​music/​package.json Raises the music example’s Express dependency minimum.

Review effort: Balanced

"resolved": "https://registry.npmjs.org/express/-/express-4.22.2.tgz",
"integrity": "sha512-IuL+Elrou2ZvCFHs18/CIzy2Nzvo25nZ1/D2eIZlz7c+QUayAcYoiM2BthCjs+EBHVpjYjcuLDAiCWgeIX3X1Q==",
"version": "4.22.3",
"resolved": "https://ms-feed-25.pkgs.visualstudio.com/1es-public/_packaging/npm-public/npm/registry/express/-/express-4.22.3.tgz",
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants