Repository navigation
Conversation
Upgrade the music example to Express 4.22.3 and resolve qs 6.16.2 without overrides or unrelated dependency updates. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Custom Azure Artifacts URLs in typescript/package-lock.json break clean installs where that feed is blocked and need to be restored to canonical npm registry URLs.
1 open issue
1 file not reviewed
typescript/package-lock.json: Generated file
What changed in this PR
Updates the music example’s Express dependency to address the reported qs security alerts while retaining Express 4 compatibility.
Changes:
- Raises the Express dependency range to
^4.22.3. - Updates the workspace lockfile to Express
4.22.3andqs6.16.2, removing the redundant nestedqscopy.
| File | Description |
|---|---|
typescript/package-lock.json |
Updates Express and qs resolutions and removes duplicate qs. |
typescript/examples/music/package.json |
Raises the music example’s Express dependency minimum. |
Review effort: Balanced
| "resolved": "https://registry.npmjs.org/express/-/express-4.22.2.tgz", | ||
| "integrity": "sha512-IuL+Elrou2ZvCFHs18/CIzy2Nzvo25nZ1/D2eIZlz7c+QUayAcYoiM2BthCjs+EBHVpjYjcuLDAiCWgeIX3X1Q==", | ||
| "version": "4.22.3", | ||
| "resolved": "https://ms-feed-25.pkgs.visualstudio.com/1es-public/_packaging/npm-public/npm/registry/express/-/express-4.22.3.tgz", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
^4.22.3, retaining Express 4 compatibility.qsto6.16.2and remove its redundant nested copy. No overrides or unrelated dependency updates.Validation
Using the repository-pinned Node.js
24.22.1:npm ci --prefer-offline --no-audit --no-fund— passed; the prepare hook also rannpm run build-allfor the library and every example.npm test— 372 passed, 0 failed or skipped.npm audit --package-lock-only --audit-level=low— 0 vulnerabilities (passed on retry after an initial feed rate limit).qsinstance meets all three alerts' patched-version thresholds, and only the music, Express, and qs lockfile entries changed.git diff --check— passed.