Repository navigation
Acknowledge accepted work and owner build commands - #510
Merged
Merged
Conversation
Confirm exact acceptance with an idempotent thumbs-up on the owner command. Add the native build rocket without granting write permissions to inference or generated checks. Preserve fail-closed publication and document verified live-run limits. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Trusted activation gains repository-write permissions, leaving the permission boundary and unverified Issue/Discussion reaction paths requiring owner review and controlled live validation before rollout.
No open issues 🎉
What changed in this PR
Adds feedback for owner acceptance and build commands without changing acceptance authority or automatically starting implementation.
Changes:
- Adds thumbs-up reactions after confirmed acceptance, with retry handling that avoids duplicate acceptance records.
- Enables rocket reactions for eligible build startup, confining reaction-write permissions to trusted activation.
- Adds regression coverage and updates operator guidance to distinguish startup, acceptance, and verified publication.
| File | Description |
|---|---|
tools/tests/implementation-workflow.test.mjs |
Checks rocket configuration and activation-only write permissions. |
tools/tests/discussion-draft.test.mjs |
Covers acceptance reactions, retries, failures, and publication races. |
tools/discussion-draft.mjs |
Acknowledges confirmed acceptance and reports reaction failures. |
OWNER-CHEATSHEET.md |
Explains reaction meanings and safe acceptance retries. |
AUTOMATION.md |
Documents acknowledgment behavior, permission boundaries, and live-pilot status. |
.github/workflows/issue-implementation.md |
Enables the native rocket startup reaction. |
.github/workflows/issue-implementation.lock.yml |
Adds the compiled reaction step and activation permissions. |
Review effort: Balanced
Tal Zaccai (TalZaccai)
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the owner-requested command feedback without changing acceptance authority or starting implementation automatically.
/typechat acceptcommand only after the exact canonical accepted-work record is confirmed./typechat buildstartup. It does not indicate successful validation or completion.Validation
Operational state
The coding activation flag remains unset. These reactions are not yet live-verified; deployment requires human review and merge. This PR does not authorize another coding run, alter accepted scope, merge a PR, or close an issue.