DelegateParameters inherit their source's settable/gettable/snapshot_value/unit/label #6648
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug observed when chaining multiple DelegateParameters, and changing the source at the bottom of the chain.
In the previous implementation, a DelegateParameter only updated it's internal
_settableand_gettableattributes when thesourcewas changed. But it is possible to set up a chain of DelegateParameters and then change the 'root' source Parameter. This updates the bottom-most DelegateParameter, but all of the other DelegateParameters in the chain will not update.This PR changes the implementation to override the
ParameterBaseimplementation of thegettableandsettableproperties, so that they reflect the underlyingsourceparameter, no matter what it may be.