Improve logger test #5419
Merged
Improve logger test #5419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Read setup log from caplog fixture rather than file. Remove the need for setting / resetting loggers in tests that do not require it.
This avoids modifying the pytest fixtures which has unintended side effects
Codecov Report
@@ Coverage Diff @@
## master #5419 +/- ##
==========================================
- Coverage 68.27% 68.27% -0.01%
==========================================
Files 341 341
Lines 29901 29901
==========================================
- Hits 20415 20414 -1
- Misses 9486 9487 +1 |
astafan8
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5418