Skip to content

log.warning instead of raise exception if measurement has been interrupted. #4801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jenshnielsen merged 3 commits into from
Nov 11, 2022
Merged

log.warning instead of raise exception if measurement has been interrupted. #4801

jenshnielsen merged 3 commits into from
Nov 11, 2022

Conversation

@grothe6
Copy link
Contributor

@grothe6 grothe6 commented Nov 10, 2022

Pull request for #4800

@grothe6 grothe6 changed the title warn instead of raise if measurement has been interrupted. log.warning instead of raise exception if measurement has been interrupted. Nov 10, 2022
@codecov
Copy link

codecov bot commented Nov 10, 2022 •
edited
Loading

Codecov Report

Merging #4801 (d81ca0a) into master (2346131) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4801      +/-   ##
==========================================
+ Coverage   68.23%   68.25%   +0.01%     
==========================================
  Files         339      339              
  Lines       32068    32070       +2     
==========================================
+ Hits        21882    21889       +7     
+ Misses      10186    10181       -5

@grothe6 grothe6 marked this pull request as ready for review November 11, 2022 11:51
@jenshnielsen
Copy link
Collaborator

jenshnielsen commented Nov 11, 2022

@grothe6 Thanks looks good. Could you add a small snippet of text to docs/changes/newsfragments/4801.improved to document the change so it will be in the changelog for the next release?

@grothe6
Copy link
Contributor Author

grothe6 commented Nov 11, 2022

@grothe6 Thanks looks good. Could you add a small snippet of text to docs/changes/newsfragments/4801.improved to document the change so it will be in the changelog for the next release?

Done

@jenshnielsen jenshnielsen enabled auto-merge (squash) November 11, 2022 12:46
@jenshnielsen jenshnielsen merged commit d8005f1 into microsoft:master Nov 11, 2022
@grothe6 grothe6 deleted the dond_dont_raise_after_interrupt branch November 11, 2022 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jenshnielsen jenshnielsen jenshnielsen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@grothe6 @jenshnielsen