Minicircuits 4SPDT driver fix for .NET 4.5+ versions #4623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guenp
reviewed
Sep 15, 2022
astafan8
reviewed
Sep 16, 2022
dfb1ea5 to
17111aa
Compare
|
@jenshnielsen and I just discussed, it looks like @ThorvaldLarsen won't have time to finish it up so Jens will take care of it. Thanks all! |
17111aa to
f1a8b15
Compare
Codecov Report
@@ Coverage Diff @@
## master #4623 +/- ##
==========================================
- Coverage 68.41% 68.39% -0.02%
==========================================
Files 353 353
Lines 32362 32369 +7
==========================================
Hits 22139 22139
- Misses 10223 10230 +7 |
Collaborator
astafan8
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two different dll files depending on the version of .NET on the system:
.Net 4.5 and above: mcl_RF_Switch_Controller_NET45.dll
Earlier .Net versions: mcl_RF_Switch_Controller64.dll
Had a quick look but couldn't find an easy way to check the .NET version from python although would expect it should be possible. The most rudimentary solution is to just try importing both and renaming the package in python as shown suggested here but would be nice with a cleaner implementation.