Repository navigation
META: Bump telemetry to 2.0.5 - #51940
Merged
Merged
Conversation
It would seem that I forgot about the existence of C++ when I fixed our telemetry in #51896. That PR only added a product ID to C# events, not C++ ones. The easiest solution for this is to honestly just add it in this nuget package, so that it's automatically added to all our events. This also fixes the oversight of #44015. That PR changed the project GUID we were logging to in C#, _but not in C++_. This explains why we were still seeing C++ telemetry, but nothing from C#. Now, both languages appropriately use the one project GUID, they both set product IDs, and hopefully all is good once again.
🧭 PR intakeVisual evidence: Not needed — The changed files do not indicate a visible UI change. No visual evidence is expected. Recommendation
✅ Ready for reviewThis PR passed the automated intake checks and is ready for maintainer review. Automated PR intake; PowerToys maintainers make final decisions. |
Boliang Zhang (LegendaryBlair)
approved these changes
Nov 5, 2026
Boliang Zhang (LegendaryBlair)
deleted the
dev/migrie/b/telemetry-2.0.5
branch
November 5, 2026 13:19
Boliang Zhang (LegendaryBlair)
pushed a commit
that referenced
this pull request
Nov 5, 2026
It would seem that I forgot about the existence of C++ when I fixed our telemetry in #51896. That PR only added a product ID to C# events, not C++ ones. The easiest solution for this is to honestly just add it in this nuget package, so that it's automatically added to all our events. This also fixes the oversight of #44015. That PR changed the project GUID we were logging to in C#, _but not in C++_. This explains why we were still seeing C++ telemetry, but nothing from C#. Now, both languages appropriately use the one project GUID, they both set product IDs, and hopefully all is good once again. (cherry picked from commit 8cfe692) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: bde9bb9c-575d-4d61-9583-ed24eed6af43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It would seem that I forgot about the existence of C++ when I fixed our telemetry in #51896. That PR only added a product ID to C# events, not C++ ones.
The easiest solution for this is to honestly just add it in this nuget package, so that it's automatically added to all our events.
This also fixes the oversight of #44015. That PR changed the project GUID we were logging to in C#, but not in C++. This explains why we were still seeing C++ telemetry, but nothing from C#.
Now, both languages appropriately use the one project GUID, they both set product IDs, and hopefully all is good once again.