Skip to content

[MWB][UITests] Fix StyleCop layout warnings (stack 3/4) - #51648

Merged
Clint Rutkas (crutkas) merged 2 commits into
crutkas-fix-mwb-uitests-ca-warningsfrom
crutkas-fix-mwb-uitests-stylecop-warnings
Nov 3, 2026
Merged

Clint Rutkas (crutkas) merged 2 commits into
crutkas-fix-mwb-uitests-ca-warningsfrom
crutkas-fix-mwb-uitests-stylecop-warnings

Conversation

@crutkas

@crutkas Clint Rutkas (crutkas) commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

Summary of the Pull Request

Mouse without border UI tests were added with allowing baseline warnings. i'm on a war against warnings. This is a stacked PR to keep the reviews small and tight.

PR Checklist

  • Closes: #xxx
  • Communication: I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end-user-facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

AI-generated summary

Stack 3/4 (base: #51647). Fixes StyleCop layout warnings in MouseWithoutBorders.UITests: SA1107, SA1116, SA1117, SA1118, SA1130, SA1501, SA1502, SA1513, and SA1515.

  • Formatting only. A whitespace-insensitive token comparison against layer 2 shows exactly two kinds of token changes:
    • anonymous delegate -> lambda (SA1130). This is C# 3 syntax, so it still compiles under Windows PowerShell 5.1.
    • hoisting the multi-line provision["Configuration"] ?? throw ... argument into a local before its loop (SA1118) in TwoEndpointFixture and EndpointRecoveryFixture.
  • Payload types intentionally stay in NativeSupport.cs / Receiver.cs here. The one-type-per-file move is layer 4, so that diff reviews as a pure move.

Validation (local, x64 Debug): msbuild exit 0, with only SA1402 x6 and SA1649 x2 remaining (fixed in layer 4); the Windows PowerShell 5.1 Add-Type payload compile passes; ClipboardObservationDistinguishesContentionFromReadableData and StartMenuIdentityRequiresExactOsPathClassAndInteractiveSession pass 2/2; Scripts\Test-SuitePreparation.ps1 passes under PS 5.1 (89 checks). Sandbox end-to-end suites were not run locally.

Formatting only for SA1107, SA1116, SA1117, SA1118, SA1130, SA1501, SA1502, SA1513 and SA1515. The only token changes are delegate-to-lambda (SA1130) and hoisting a multi-line argument into a local (SA1118).
@github-actions github-actions Bot added Product-Mouse Without Borders Refers to the Mouse Without Borders module Ready for review labels Oct 28, 2026
@github-actions

Copy link
Copy Markdown

🧭 PR intake

Visual evidence: Not needed — The changed files do not indicate a visible UI change. No visual evidence is expected.

Recommendation

Link the issue this PR fixes using a closing keyword such as Closes #123.

✅ Ready for review

This PR passed the automated intake checks and is ready for maintainer review.

Automated PR intake; PowerToys maintainers make final decisions.

@crutkas

Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

The StyleCop layout fix expands the one-line delegating wrapper, which broke an exact single-line source match in mwbEndpointDiagnostics.Tests.ps1.
@crutkas
Clint Rutkas (crutkas) merged commit 99537d3 into main Nov 3, 2026
13 checks passed
@crutkas
Clint Rutkas (crutkas) deleted the crutkas-fix-mwb-uitests-stylecop-warnings branch November 3, 2026 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Product-Mouse Without Borders Refers to the Mouse Without Borders module Ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants