Repository navigation
Fix: Mouse Without Borders Quick Access label shows generic module name instead of 'Reconnect' (#48550) - #50909
Merged
Boliang Zhang (LegendaryBlair) merged 1 commit intoNov 3, 2026
Conversation
…ad of generic module name PR microsoft#46025 added MWB to Quick Access but used the generic module label which returns 'Mouse Without Borders'. This was confusing because the item appears to open settings but actually only triggers a reconnect. Added GetModuleItemTitle() to use the specific resource 'MouseWithoutBorders_ReconnectButton/Text' ('Reconnect') for MWB.
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
Author
|
@microsoft-github-policy-service agree |
Boliang Zhang (LegendaryBlair)
approved these changes
Nov 3, 2026
Contributor
|
/azp run |
Boliang Zhang (LegendaryBlair)
enabled auto-merge (squash)
November 3, 2026 05:27
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Boliang Zhang (LegendaryBlair)
merged commit Nov 3, 2026
7c58f9a
into
microsoft:main
9 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #48550
Summary
PR #46025 added the Mouse Without Borders 'Refresh connections' action to Quick Access, but it used the generic module label (\ModuleHelper.GetModuleLabelResourceName(moduleType)) which returns 'Mouse Without Borders'.
This was confusing because the Quick Access item appeared to be a link to open the MWB settings page, but it actually only triggers a reconnect/refresh of connections.
Fix
Changed \QuickAccessViewModel.cs\ to use the specific resource string \MouseWithoutBorders_ReconnectButton/Text\ ('Reconnect') for the title when the module type is \MouseWithoutBorders, while keeping the generic label for all other modules.
Added a new private method \GetModuleItemTitle(ModuleType moduleType)\ that handles this special case.