Repository navigation
CmdPal: Move bookmarks with placeholders to be parameters - #47886
Merged
Merged
Conversation
The placeholders page for a bookmark is already goofy. It's a seemingly simple form, for just filling in something that really should be an inline value. So let's do that! This moves the placeholders out of a whole adaptive card, and into an inline parameter. Targets (the pr that targets #47826)
Michael Jolley (michaeljolley)
previously approved these changes
May 14, 2026
This PR is stacked on top of #47826 This augments the previous PR to add support for List parameters too. This allows extensions to add parameters where the "command" to select a value is just a `IListPage`. That lets the extension author specify a set of possible values, and let us handle the rendering of that list. The canonical example is the `CreateNoteParametersPage`, in `ParameterSamples.cs`. In that sample, there's a set of possible values for the folder param. The extension exposes that to us, and we can then let the user navigate that list just like any other list page. https://github.com/user-attachments/assets/ecafc5fc-ed43-4554-94ff-80ca96e8c83e Unfortunately, this kinda means that we need to refactor ListPage a bit. We need to slice it, so that we can have the list itself as it's own control, separate from the "page". This lets us easily add the `ListItemsView` to the parameters page too. All of that code should basically be copied verbatim. Sorry that github will have a hard time comparing the two.
Base automatically changed from
dev/migrie/f/parameters-list
to
dev/migrie/f/parameters-2026
May 15, 2026 14:30
…to dev/migrie/f/bookmark-params
Mike Griese (zadjii-msft)
dismissed
Michael Jolley (michaeljolley)’s stale review
May 16, 2026 01:40
The base branch was changed.
Mike Griese (zadjii-msft)
enabled auto-merge (squash)
May 16, 2026 01:40
Michael Jolley (michaeljolley)
approved these changes
May 16, 2026
Niels Laute (niels9001)
added a commit
that referenced
this pull request
May 17, 2026
These files were intentionally deleted on main by recent PRs but were resurrected when 7aae734 merged main with a bad conflict resolution: - HideWindowMessage.cs (deleted by #47826 CmdPal parameters) - BookmarkPlaceholderForm.cs (deleted by #47886 bookmarks-as-parameters) - NativeMethods.json/.txt + WindowsPackageManager.Interop/* (deleted by #46636 Extension Gallery) - Ext.Indexer/Assets/Actions.png (moved/deleted by #46636) - DdcCiValidationResult.cs (deleted by #47875 PowerDisplay max-compat) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The placeholders page for a bookmark is already goofy. It's a seemingly simple form, for just filling in something that really should be an inline value.
So let's do that!
This moves the placeholders out of a whole adaptive card, and into an inline parameter.
Targets #47885