Skip to content

[PowerDisplay] Use localized "Built-in Display" name for internal display - #47321

Merged
Boliang Zhang (LegendaryBlair) merged 2 commits into
mainfrom
yuleng/pd/hot/4
Apr 29, 2026
Merged

Boliang Zhang (LegendaryBlair) merged 2 commits into
mainfrom
yuleng/pd/hot/4

Conversation

@moooyo

@moooyo Yu Leng (moooyo) commented Apr 28, 2026 •

Copy link
Copy Markdown
Contributor

Set all WMI monitor's name to "Built-in Display" to avoid confusing.

related discussion: #47255

Summary of the Pull Request

PR Checklist

  • Closes: #
  • Communication: I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end-user-facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

…plays

Replace the PnP-manufacturer-derived names (e.g. "Lenovo Built-in Display",
"BOE Built-in Display") for WMI-discovered internal displays with a single,
localized "Built-in Display" string injected at the ViewModel layer.

- Add BuiltInDisplayName resource string (en-us)
- MonitorViewModel.Name returns the localized string when IsInternal
- WmiController leaves Monitor.Name blank; PnpIdHelper is no longer needed
- Delete PnpIdHelper.cs and its 27-entry manufacturer map

Display numbering ("Built-in Display 1", "Dell U2723QE 2") is unaffected:
MonitorNumber comes from QueryDisplayConfig and is independent of Name.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@github-actions

This comment has been minimized.

…resw

Co-authored-by: Niels Laute <niels.laute@live.nl>
@moooyo

Copy link
Copy Markdown
Contributor Author

accept Niels Laute (@niels9001) suggestion.

@github-actions

Copy link
Copy Markdown

check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, 👼 SARIF report, or 📝 job summary for details.

Unrecognized words (1)

DEFAULTTONEAREST

These words are not needed and should be removed ACR ASUS Chunghwa CSOT defaulttonearest Hann HWP IVO Nanjing PHL QDS Tianma

To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands

... in a clone of the git@github.com:microsoft/PowerToys.git repository
on the yuleng/pd/hot/4 branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/cfb6f7e75bbfc89c71eaa30366d0c166f1bd9c8c/apply.pl' |
perl - 'https://github.com/microsoft/PowerToys/actions/runs/25086897571/attempts/1' &&
git commit -m 'Update check-spelling metadata'

OR

To have the bot accept them for you, comment in the PR quoting the following line:
check-spelling-bot apply updates.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@LegendaryBlair
Boliang Zhang (LegendaryBlair) merged commit 2aece74 into main Apr 29, 2026
15 checks passed
@crutkas
Clint Rutkas (crutkas) deleted the yuleng/pd/hot/4 branch May 25, 2026 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants