Repository navigation
fix: dv-admin, dv-connect and ERP routing for consistent evals - #158
Closed
Saurabh Ravindra Badenkal (saurabhrb) wants to merge 4 commits into
Closed
Saurabh Ravindra Badenkal (saurabhrb) wants to merge 4 commits into
Saurabh Ravindra Badenkal (saurabhrb) wants to merge 4 commits into
Conversation
Saurabh Ravindra Badenkal (saurabhrb)
marked this pull request as ready for review
October 15, 2026 16:21
PR-gate dry-run evals showed two ERP routing misses: - A preview of an ERP record update loaded dv-overview, found complete create/update/delete templates in references/erp-target.md, and answered without loading dv-data. The answer was right but bypassed the skill that owns ERP writes. erp-target.md now keeps the read templates and sends writes, including previews, to dv-data, whose erp-writes.md has the templates. Batch jobs likewise point to dv-admin. - 'Show me the latest Finance and Operations batch jobs' matched dv-query's 'ERP (Finance and Operations / F&O) ... reads' and never reached dv-admin, whose description said only 'ERP batch jobs'. dv-admin now names Finance and Operations, and dv-query's boundaries send ERP writes to dv-data and batch jobs to dv-admin instead of linking another skill's reference file. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Saurabh Ravindra Badenkal (saurabhrb)
pushed a commit
that referenced
this pull request
Oct 17, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…cialists' templates A PR-gate dry run showed the same skip for ERP reads: asked to inspect an ERP entity's schema, the agent loaded dv-overview, copied the 'data describe --target erp' template from references/erp-target.md and never loaded dv-query. The reference also still repeated dv-data's write templates under 'Writes for ERP', contradicting the previous commit's note that they are not repeated here. erp-target.md now routes reads, counts and runtime schema discovery to dv-query (references/erp-reads.md) and writes to dv-data (references/erp-writes.md), and keeps only routing, the ERP-vs-Dataverse differences, Custom Services, X++ and scope notes. Every removed template is still in the owning skill's reference. Also corrects 'DMF (tier 5 above)' to tier 6. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Saurabh Ravindra Badenkal (saurabhrb)
pushed a commit
that referenced
this pull request
Oct 17, 2026
…router) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Routing fixes so the dv-admin and dv-connect live evals and the ERP dry-run evals pass consistently. None adds a new capability.
Why
Over the last 16 live-eval runs, each of these failures recurred, and each traced back to skill guidance rather than to the platform.
dv-connect (7 failing runs): every dv-connect failure was the same.
connect_001orconnect_002asks the agent to verify an existing connection (WhoAmI, or check thatDATAVERSE_URLmatches the live org). The agent answered correctly, scoring Correctness 5/5, but never loadeddv-connect, which fails that suite's skill-loaded check. The cause is in dv-overview: it sends "connect" and "set up" requests todv-connectunconditionally, but tells the agent to skip setup when auth already works. A "verify the connection" request in an already-authenticated workspace matched only the skip path.dv-admin (1 of 8 graded runs): a request for named OrgDB settings could leave out any setting that has never been written. The existing "read all OrgDB settings" example only iterates keys that are present, so the agent either dropped the missing key or improvised a "not configured" line.
ERP routing (PR-gate dry-run evals): three tests failed on routing, not on the answer.
erp_data_001_update_contract(2 of 3 runs): asked to preview an ERP record update, the agent loaded dv-overview, found complete create/update/delete templates inreferences/erp-target.md, and answered without loadingdv-data, although the same file says write previews must load it. The answers scored 5/5; the skill-loaded check failed.erp_admin_001_list_running(1 of 3 runs): "Show me the latest Finance and Operations batch jobs" matched dv-query's "ERP (Finance and Operations / F&O) ... reads". The agent loaded dv-query, never reached dv-admin's batch-job guidance, and spent the run on auth checks instead ofdataverse erp batch list.erp_metadata_001_runtime_schema(1 of 3 graded runs): the same skip for reads. The agent copied thedata describe --target erptemplate fromreferences/erp-target.mdand never loadeddv-query.What changed
dv-overview/SKILL.md: "verify connection" requests now loaddv-connect, alongside "connect" and "set up". The trailing explanatory clause was dropped to keep the body under the 5,000-token Level 2 cap.dv-admin/references/orgdb-settings.md: new "read specific OrgDB settings" example thatnot set (platform default)rather than skipping it,The allowlist in the example was verified to match the 17-key table in the same file exactly. dv-admin's
SKILL.mdis unchanged because its body is already within a few tokens of the cap.dv-overview/references/erp-target.mdis a router again, as its opening line says: reads, counts and runtime schema discovery point todv-query(references/erp-reads.md), writes including previews todv-data(references/erp-writes.md), and batch jobs todv-admin. The command templates now live only in those references; every removed template is still there. Also corrects "DMF (tier 5 above)" to tier 6.dv-admindescription: names Finance and Operations / F&O for batch jobs, matching how users ask.dv-queryskill boundaries: ERP writes go todv-dataand batch jobs todv-admin, instead of linking another skill's reference file.Version bumped 1.16.1 -> 1.16.2 (PATCH). This covers every manifest checked by
static_checks.py, including both Gemini manifests and the operation-context string.How to test
python .github/evals/static_checks.pypasses.dv-connectto load.dv-datato load.dv-adminto load anddataverse erp batch listto be used.Live validation
Both fixes were run against a live test environment with the updated test suite:
connect_001andconnect_002, which previously skipped loadingdv-connect.Each fix has one passing live run so far; nightly runs will show whether that holds.
Round 2 (10/17, ERP routing), with #155 on the same combined proof branch:
erp_data_001_update_contract,erp_admin_001_list_runninganderp_metadata_001_runtime_schemaeach failed a skill-loaded check in at least one run. Each now loads the owning skill: dv-data, thenerp-writes.md; dv-admin, thendataverse erp batch list --company USMF --json; dv-query, thenerp-reads.md.connect_002produced no output in the evaluation harness (infrastructure), so it was not graded in this run.