Skip to content

add: run the migrated PR eval pipeline as a dry-run alongside the existing gate - #156

Open
Saurabh Ravindra Badenkal (saurabhrb) wants to merge 6 commits into
mainfrom
users/saurabhrb/add-migrated-pr-eval-gate
Open

Saurabh Ravindra Badenkal (saurabhrb) wants to merge 6 commits into
mainfrom
users/saurabhrb/add-migrated-pr-eval-gate

Conversation

@saurabhrb

@saurabhrb Saurabh Ravindra Badenkal (saurabhrb) commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Why

The pull-request evaluation pipeline is moving to a shared evaluation template so that changes to the evaluation (test corpus, agent, model, runner) no longer need edits in this repository.

What changed

  • New .azdo/DataversePluginEvals_PR_Migrated.yml. A thin pipeline file that only declares its trigger/pr branches and a repository resource, then extends the evaluation template. The repository resource reads the template through a service connection dedicated to this gate rather than one other pipelines share. The file carries no evaluation settings. No pipeline builds it yet.
  • README.md: new "Evaluation" section explaining that pull requests run automated dry-run evaluations, that the existing file stays the gate until the new one replaces it, and what contributors should run locally.
  • The existing .azdo/DataversePluginEvals_PR.yml is unchanged and remains the gate, including the bearer-token change from ci: [DDC-Agent] attach a bearer token to BIC Evaluation Service calls in PR evals #166.

Rollout

  1. Merge this PR. Nothing changes for pull requests: the existing gate still runs, and no pipeline builds the new file yet.
  2. The replacement evaluation is measured on internal runs against pull-request revisions.
  3. At the cutover, a pipeline starts building the new file, its check becomes required, and a follow-up PR removes the existing pipeline file and the test files it uses.

Validation

  • python .github/evals/static_checks.py: passed, on this branch merged with current main.
  • python .github/evals/check_action_pins.py: no violations.
  • A compile-only pipeline preview of the new file (no run queued) compiled with no errors on an earlier revision. It has not been re-run since the service connection changed, because no pipeline builds this file yet; it will be re-validated when one does.

Saurabh Badenkal and others added 5 commits October 14, 2026 21:10
…se LF line endings

No pipeline builds .azdo/DataversePluginEvals_PR_Migrated.yml until the cutover, so the existing file stays the only pull request gate. The file comment and the README's Evaluation section now say so. The file now uses LF line endings like the rest of the repository.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ction

The migrated pull request gate now reads bic/dataverse-plugin through a
service connection dedicated to it, instead of a connection other pipelines
share. No pipeline builds this file yet.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The README inaccurately describes the corpus as already external, although the checked-in corpus still gates PRs, so contributor guidance needs to distinguish it from the replacement pipeline’s corpus.

1 open issue
What changed in this PR

Prepares the Dataverse plugin’s PR evaluations to use a shared template while leaving the existing gate unchanged. The new pipeline file remains inactive until a pipeline is configured to build it.

Changes:

  • Adds a thin pipeline definition referencing the shared evaluation template through a dedicated service connection.
  • Documents the migration and contributors’ local validation steps.
File Description
README.md Adds evaluation guidance and explains the gate transition.
.azdo/​DataversePluginEvals_PR_Migrated.yml Declares main triggers and extends the shared evaluation template.

Review effort: Balanced

Comment thread README.md Resolved
…lacement pipeline's

The current PR gate still reads the corpus under evals/tests/; only the replacement pipeline's corpus lives outside this repository. Addresses review feedback on #156.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The external evaluation template was inaccessible and the compile preview predates the service-connection change, requiring an authorized maintainer to verify template resolution and connection access before enabling the replacement gate.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants