Skip to content

Refactor GenShell #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
prupipho merged 7 commits into from
Jun 8, 2021
Merged

Refactor GenShell #328

prupipho merged 7 commits into from
Jun 8, 2021

Conversation

@dgomezc
Copy link
Collaborator

@dgomezc dgomezc commented May 28, 2021

PR checklist

  • Quick summary of changes
    • Split GenShell in multiple classes and interfaces
    • Adapt Core, Cli and Test projects
  • Which issue does this PR relate to?

@prupipho prupipho marked this pull request as draft June 8, 2021 15:49
@prupipho prupipho marked this pull request as ready for review June 8, 2021 15:49
@prupipho prupipho merged commit cd6d0c8 into microsoft:dev Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sibille sibille sibille approved these changes

@KirillShchetinin KirillShchetinin Awaiting requested review from KirillShchetinin

@mvegaca mvegaca Awaiting requested review from mvegaca mvegaca is a code owner

+1 more reviewer

@prupipho prupipho prupipho approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dgomezc @prupipho @sibille