Skip to content

Support "all" tag when get project types #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prupipho merged 3 commits into from
May 21, 2021
Merged

Support "all" tag when get project types #322

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9127e6b
Support "all" tag when get project types
May 19, 2021
c879a89
Support "all" tag when get project types in GetSupportedFx method
May 20, 2021
cc4657b
Merge remote-tracking branch 'upstream/dev' into 279-GetAllProjectTypes
May 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions code/src/CoreTemplateStudio/CoreTemplateStudio.Core/Templates/TemplatesRepository.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ public ITemplateInfo Find(Func<ITemplateInfo, bool> predicate)
public IEnumerable<MetadataInfo> GetProjectTypes(UserSelectionContext context)
{
var projectTypes = GetSupportedProjectTypes(context);
return GetMetadataInfo("projectTypes").Where(m => m.Platform == context.Platform && projectTypes.Contains(m.Name));
return GetMetadataInfo("projectTypes").Where(m => m.Platform == context.Platform && (projectTypes.Contains(m.Name) || projectTypes.Contains(All)));
}

public IEnumerable<MetadataInfo> GetFrontEndFrameworks(UserSelectionContext context)
Expand Down Expand Up @@ -317,7 +317,7 @@ private IEnumerable<SupportedFramework> GetSupportedFx(UserSelectionContext cont
{
var filtered = GetAll()
.Where(t => t.GetTemplateType() == TemplateType.Project
&& t.GetProjectTypeList().Contains(context.ProjectType)
&& (t.GetProjectTypeList().Contains(context.ProjectType) || t.GetProjectTypeList().Contains(All))
&& IsMatchPropertyBag(t, context.PropertyBag)
&& t.GetPlatform().Equals(context.Platform, StringComparison.OrdinalIgnoreCase)).ToList();

Expand Down