Skip to content

kindnet: bump kindnetd to v20260820-69b56db7 - #239

Merged
ggiguash merged 1 commit into
microshift-io:mainfrom
mkocustos:kindnet-bump-v20260820
Sep 8, 2026
Merged

ggiguash merged 1 commit into
microshift-io:mainfrom
mkocustos:kindnet-bump-v20260820

Conversation

@mkocustos

@mkocustos mkocustos commented Sep 3, 2026 •

Copy link
Copy Markdown
Contributor

The pinned kindnetd digest dates from 2025-05-12 and is now 15 months old.
generate_manifests.sh always resolves the latest tag from Docker Hub, so this
is simply the result of re-running it — the assets had not been regenerated
since the original pin.

What this fixes

Two CRITICAL findings in the kindnetd binary itself:

CVE Component Before After
CVE-2026-33186 (9.1) google.golang.org/grpc v1.72.0, authz bypass fixed
CVE-2025-68121 Go stdlib 1.24.2 built with Go 1.26.7

Two CRITICALs remain in the new image, both outside bin/kindnetd and not
fixable here: CVE-2025-68121 in the go-runner helper (Go 1.25.6) and
CVE-2026-31789 in the Debian base (libssl3 3.0.18, fix lands in 3.0.19).

Why it is drop-in

The DaemonSet passes no args and no command; kindnetd is configured purely
through HOST_IP, POD_IP and POD_SUBNET. I extracted both binaries and
compared them: same entrypoint (/bin/kindnetd), same CLI surface (logging
flags only), and all three environment variables present in both.

POD_SUBNET matters in particular, because getting it wrong is what breaks
source-IP preservation behind the router (see #236).

Verified on a running cluster

Installed on MicroShift 4.22 (Kubernetes v1.35.6), single node, kindnet as CNI:

  • DaemonSet and RPM manifest agree on the new digest, no drift
  • POD_SUBNET stays 10.42.0.0/16 on both sides
  • kindnet pod Running, 0 restarts; 53/53 pods healthy after the restart
  • KIND-MASQ-AGENT still carries the RETURN for the pod CIDR, and real
    external client IPs continue to arrive in X-Forwarded-For — so source-IP
    preservation is intact
  • Trivy: 4 CRITICAL -> 2 on this image

Scope

Only the kindnet assets are regenerated. Re-running the script also bumps
kube-proxy to v1.37.0, which is deliberately left out: that image has to track
the cluster's Kubernetes version rather than the newest published tag, and on
a 1.35 cluster it would be two minor versions ahead.

Summary by CodeRabbit

  • Chores
    • Updated the pinned kindnet container image versions for ARM64 and x86_64 platforms.
    • Ensured release assets reference the updated kindnet image digests.

The pinned kindnetd digest dates from 2025-05-12 and is now 15 months old.
generate_manifests.sh always resolves the latest tag from Docker Hub, so this
is simply the result of re-running it; the assets had not been regenerated
since the original pin.

This clears two CRITICAL findings in the kindnetd binary itself:

  CVE-2026-33186  google.golang.org/grpc  v1.72.0 -> fixed (authz bypass, 9.1)
  CVE-2025-68121  Go stdlib               1.24.2  -> built with Go 1.26.7

Two CRITICALs remain in the new image, both outside bin/kindnetd and not
fixable here: CVE-2025-68121 in the go-runner helper (Go 1.25.6) and
CVE-2026-31789 in the Debian base (libssl3 3.0.18, fix lands in 3.0.19).

The DaemonSet passes no args or command and configures kindnetd purely through
HOST_IP, POD_IP and POD_SUBNET. Both binaries were extracted and compared:
entrypoint (/bin/kindnetd), the CLI surface (logging flags only) and all three
environment variables are unchanged, so the bump is drop-in. POD_SUBNET in
particular is still honoured, which matters because getting it wrong is what
breaks source-IP preservation (see microshift-io#236).

Only the kindnet assets are regenerated here. Re-running the script also bumps
kube-proxy to v1.37.0, which is left out on purpose: that image has to track
the cluster's Kubernetes version rather than the newest published tag.
@mkocustos
mkocustos requested a review from a team as a code owner September 3, 2026 17:16
@coderabbitai

coderabbitai Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 6737819c-dc2d-4f7b-b79e-b813f8da3703

📥 Commits

Reviewing files that changed from the base of the PR and between d296377 and de96ea1.

📒 Files selected for processing (4)
  • src/kindnet/assets/kindnet/kustomization.aarch64.yaml
  • src/kindnet/assets/kindnet/kustomization.x86_64.yaml
  • src/kindnet/assets/kindnet/release-kindnet-aarch64.json
  • src/kindnet/assets/kindnet/release-kindnet-x86_64.json

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The pull request updates pinned kindnet container image digests in architecture-specific kustomization and release asset files for aarch64 and x86_64.

Changes

Kindnet image digest updates

Layer / File(s) Summary
Update architecture-specific image references
src/kindnet/assets/kindnet/kustomization.*.yaml, src/kindnet/assets/kindnet/release-kindnet-*.json
Updates the pinned kindnet image digests in the aarch64 and x86_64 kustomization and release assets.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to de96e

This updates the pinned kindnet image digests consistently across release assets for both supported architectures. No current merge-blocking risk remains.

Suggested reviewers: agullon, brandisher, copejon

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: updating kindnetd to version v20260820-69b56db7.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (4 skipped: 4 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ggiguash ggiguash self-assigned this Sep 3, 2026
@ggiguash
ggiguash merged commit 57c8f82 into microshift-io:main Sep 8, 2026
12 of 15 checks passed
@mkocustos
mkocustos deleted the kindnet-bump-v20260820 branch September 8, 2026 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants