-
Notifications
You must be signed in to change notification settings - Fork 12
chore(workflows/build): simplify build matrix strategy #246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR simplifies the build matrix strategy in the GitHub Actions workflow by consolidating runner and architecture configurations into a single nested structure. The change reduces complexity by eliminating the need for extensive exclusion rules and conditional logic for determining runners.
- Restructured the build matrix to use a nested
buildobject containing bothrunnerandarchsfields - Simplified the job name and runs-on expressions by referencing the consolidated matrix structure
- Streamlined exclude and include rules to use the new nested format
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/build.yml | Consolidated build matrix strategy using nested build objects and updated all references to use the new structure |
| .github/workflows/tests-with-pydebug.yml | Minor formatting fix to reorder the uses and id fields in the pyenv cache step |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
f69cbe5 to
177ad29
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #246 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 14 14
Lines 1403 1403
Branches 173 173
=========================================
Hits 1403 1403 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
177ad29 to
afe8d0c
Compare
Description
Describe your changes in detail.
Motivation and Context
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax
close #15213if this solves the issue #15213Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Checklist
Go over all the following points, and put an
xin all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!
make format. (required)make lint. (required)make testpass. (required)