Fix macro invocation with post-increment index as argument #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In WebRequest.cpp at line 150: while (i<len && __is_param_char(((char*)buf)[i++])); the macro __is_param_char will expand producing multiple i++ invocations making the algorithm to (sometimes) fail.
Small bug fix at WebRequest.cpp
There was a problem hiding this comment.
I agree: this looks like a bug. "__is_param_char" macro expansion will cause multiple increments of i++. That is a dangerous macro. Rather than a macro, perhaps we should be using a function here?
bool is_param_char(char c) {
return
(c != 0) &&
(c != '{') &&
(c != '[') &&
(c != '&') &&
(c != '=');
}
From reading your code, it should also work around the bug, but I can't test it.
Edit: explicitly test c for null (c!=0) instead of (c).
|
Yes, I also think is best to replace the macro with a function. |
|
@me-no-dev Please review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In WebRequest.cpp at line 150:
while (i<len && __is_param_char(((char*)buf)[i++]));the macro
__is_param_charwill expand producing multiplei++invocations making the algorithm to (sometimes) fail.