Skip to content

Fix erasure of Integrator subsytem, remove OpenMDAO upper bound - #83

Merged
kanekosh merged 9 commits into
mainfrom
OM340
Oct 17, 2025
Merged

kanekosh merged 9 commits into
mainfrom
OM340

Conversation

@A-CGray

@A-CGray A-CGray commented Sep 29, 2025 •

Copy link
Copy Markdown
Member

Purpose

Fixes OpenMDAO/OpenMDAO#3621, making OpenConcept compatible with latest version of OpenMDAO.

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • - Bugfix (non-breaking change which fixes an issue)
  • - New feature (non-breaking change which adds functionality)
  • - Breaking change (non-backwards-compatible fix or feature)
  • - Code style update (formatting, renaming)
  • - Refactoring (no functional changes, no API changes)
  • - Documentation update
  • - Other (please describe)

Testing

Explain the steps needed to test the new code to verify that it does indeed address the issue and produce the expected behavior.

Checklist

Put an x in the boxes that apply.

  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@A-CGray
A-CGray requested a review from a team as a code owner September 29, 2025 23:22
@codecov

codecov Bot commented Sep 29, 2025 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.05%. Comparing base (e5fccbb) to head (688e099).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #83   +/-   ##
=======================================
  Coverage   82.04%   82.05%           
=======================================
  Files         103      103           
  Lines       10724    10729    +5     
=======================================
+ Hits         8799     8804    +5     
  Misses       1925     1925           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@A-CGray

A-CGray commented Oct 2, 2025

Copy link
Copy Markdown
Member Author

Failing tests are being caused by pyCycle, I've opened this PR to fix the issue

@A-CGray

A-CGray commented Oct 15, 2025

Copy link
Copy Markdown
Member Author

@kanekosh OpenMDAO/pyCycle#109 is now merged, but we need to wait for a new pyCycle release to be made before our tests will pass

@A-CGray

A-CGray commented Oct 16, 2025

Copy link
Copy Markdown
Member Author

This should be good to go now @kanekosh shall we also bump the version?

@kanekosh
kanekosh merged commit e304402 into main Oct 17, 2025
@kanekosh
kanekosh deleted the OM340 branch October 17, 2025 13:28
@kanekosh kanekosh mentioned this pull request Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Subsystems added during _setup_procs are ignored

2 participants