Skip to content

Modified TMS components to allow external use by Dymos/Aviary - #78

Merged
kanekosh merged 3 commits into
mdolab:mainfrom
kanekosh:tms-update
Jul 15, 2025
Merged

kanekosh merged 3 commits into
mdolab:mainfrom
kanekosh:tms-update

Conversation

@kanekosh

Copy link
Copy Markdown
Contributor

Purpose

Added a few options to the TMS components to allow Dymos/Aviary to use our TMS components. These edits don't change how OpenConcept works.

  • Optionally remove tags from the motor and battery cooling components' outputs. OpenConcept uses the tags to figure out mission integration, but these tags cause conflict with Dymos when doing temperature integration. So I added an option to remove tags.
  • Optionally remove linear interpolator for battery loop bypass control. This allows Dymos to treat the bypass control as its optimal control variable.

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • New feature (non-breaking change which adds functionality)

Testing

Explain the steps needed to test the new code to verify that it does indeed address the issue and produce the expected behavior.

Checklist

Put an x in the boxes that apply.

  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@kanekosh
kanekosh requested a review from a team as a code owner July 15, 2025 12:16
@kanekosh
kanekosh requested a review from hajdik July 15, 2025 12:33
@kanekosh
kanekosh merged commit bceb4fc into mdolab:main Jul 15, 2025
@codecov

codecov Bot commented Jul 15, 2025 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.06%. Comparing base (3ae978f) to head (da29b16).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
- Coverage   82.06%   82.06%   -0.01%     
==========================================
  Files         103      103              
  Lines       10706    10715       +9     
==========================================
+ Hits         8786     8793       +7     
- Misses       1920     1922       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants