Repository navigation
Modified TMS components to allow external use by Dymos/Aviary - #78
Merged
Merged
Conversation
hajdik-electra
approved these changes
Jul 15, 2025
sabakhshi
approved these changes
Jul 15, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #78 +/- ##
==========================================
- Coverage 82.06% 82.06% -0.01%
==========================================
Files 103 103
Lines 10706 10715 +9
==========================================
+ Hits 8786 8793 +7
- Misses 1920 1922 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Added a few options to the TMS components to allow Dymos/Aviary to use our TMS components. These edits don't change how OpenConcept works.
tagsfrom the motor and battery cooling components' outputs. OpenConcept uses the tags to figure out mission integration, but these tags cause conflict with Dymos when doing temperature integration. So I added an option to removetags.Type of change
What types of change is it?
Select the appropriate type(s) that describe this PR
Testing
Explain the steps needed to test the new code to verify that it does indeed address the issue and produce the expected behavior.
Checklist
Put an
xin the boxes that apply.