Skip to content

Lots of new models for clean sheet aircraft design - #64

Merged
eytanadler merged 271 commits into
mdolab:mainfrom
eytanadler:aircraft_design_update
Mar 25, 2024
Merged

eytanadler merged 271 commits into
mdolab:mainfrom
eytanadler:aircraft_design_update

Conversation

@eytanadler

@eytanadler eytanadler commented Mar 11, 2024 •

Copy link
Copy Markdown
Collaborator

Purpose

This PR includes a host of new features for aircraft design purposes, many of which were developed for this paper. These include

  • Weight buildup for tube and wing configuration
  • Weight buildup for BWB configuration
  • Drag buildup for tube and wing configuration
  • Drag buildup for BWB configuration
  • Empirical CLmax estimates
  • Critical section VLM-based CLmax estimate
  • Other miscellaneous components (such as tail volume coefficient comps)
  • Bumps oldest OpenMDAO version from 3.10 to 3.21 (3.10 didn't actually work, but it wasn't being properly tested, I fixed that too)
  • Added upper bound to OpenMDAO version (see OpenMDAO v3.31 internal _setup_procs change breaks PhaseGroup and IntegratorGroup #65)

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • New feature (non-breaking change which adds functionality)

Testing

Explain the steps needed to test the new code to verify that it does indeed address the issue and produce the expected behavior.

Checklist

Put an x in the boxes that apply.

  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

bbrelje and others added 30 commits September 25, 2020 16:17
…ic derivatives and create a full duct model that can take an external HX model as connections
* First dymos-based phase

* add hybrid engine surrogate model

* Add ISA temp offset to standard atmosphere

* Add dymos to requirements

* Install dymos from git

* continued install problems

* remove dymos test scratch folder

* pin openmdao for now

* identify why 737 test is failing

* Fix trajectory test bugs introduced during dymos work

* Add a "BasicMission" with a ground roll phase that's not a real BFL phase

* Minor change to CFM56 surrogate

* Add tags to the mult-div comp

* Convergence improvements for the incompressible duct. Add some analytic derivatives and create a full duct model that can take an external HX model as connections

* Added lower bounds on some components

* various tweaks to duct test group for diagnostics

* Limit throttle to 1.05 rated

* Tweaks and doc updates to N3hybrid model

* remove dymos

* remove dymos import, reduce tol on B737 test due to differences in scipy model training behavior

* Add heat sinks specific to motors and batteries

* Further reduce tol of 738 test

* Fix docstring indentation
@codecov

codecov Bot commented Mar 11, 2024 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.08%. Comparing base (5f2cb40) to head (41c4ec5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
+ Coverage   79.98%   82.08%   +2.09%     
==========================================
  Files          85      103      +18     
  Lines        9300    10717    +1417     
==========================================
+ Hits         7439     8797    +1358     
- Misses       1861     1920      +59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kanekosh kanekosh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added minor comments, overall looks good. I appreciate your effort on thorough docstrings and tests.
It would be great to have another reviewer because this is a big addition and I don't think I caught everything.

Comment thread doc/features/aerodynamics.rst Resolved
Comment thread doc/features/aerodynamics.rst Resolved
Comment thread openconcept/aerodynamics/drag_BWB.py Resolved
Comment thread openconcept/examples/B738_sizing.py Resolved
Comment thread openconcept/examples/B738_sizing.py Resolved
Comment thread openconcept/mission/profiles.py Outdated
self.connect("rotate.fltcond|h_final", "climb.ode_integ_phase.fltcond|h_initial")


class FullMissionWithReserve(TrajectoryGroup):

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to use FullMissionAnalysis and MissionWithReserve groups here? That can reduce the code duplication.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have ideas on how that'd work? Maybe there's a way to break out sections into separate functions and then within each group's setup, pass self to the function for each section, but that feels a bit weird to me.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't think that much. My idea was to add FullMissionAnalysis and/orMissionWithReserve under this group and add linkages and additional mission phases as necessary, but it looks like it's not that simple. So never mind.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking about how to combine the two to get FullMissionWithReserve, but you make a good point that maybe I can go the other way and have the other two "inherit" from the combined one. Let me think on it a bit more.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a solution that removes the duplicated code and preserves backward compatibility. It involves a bunch of if statements, which feels a bit hacky. But I think it's a better solution than the duplicated code I initially submitted.

@eytanadler
eytanadler requested a review from kanekosh March 20, 2024 16:02
Comment thread setup.py Resolved
@eytanadler
eytanadler merged commit ed14c54 into mdolab:main Mar 25, 2024
@eytanadler
eytanadler deleted the aircraft_design_update branch March 25, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants