Skip to content

Formatting and linting - #135

Merged
ewu63 merged 9 commits into
mdolab:masterfrom
sseraj:format-lint
Mar 27, 2021
Merged

ewu63 merged 9 commits into
mdolab:masterfrom
sseraj:format-lint

Conversation

@sseraj

@sseraj sseraj commented Mar 26, 2021

Copy link
Copy Markdown
Collaborator

Purpose

Closes #98

Please review the linting changes carefully and comment if it's unclear why I made a certain change.

For flake8, I ignored

src_cs/build/complexify.py
adflow/pyWeightAndBalance.py
adflow/pyWingCG.py

The latter two are extremely outdated and should probably be removed from the repo. I can remove them in this PR or we can address that later. Similarly, we may also want to remove pyDynamicPerformance.py and pyPerformanceClass.py.

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Explain the steps needed to test the new code to verify that it does indeed address the issue and produce the expected behavior.

Checklist

Put an x in the boxes that apply.

  • I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@sseraj
sseraj requested a review from a team as a code owner March 26, 2021 19:36
@sseraj
sseraj requested review from anilyil and joanibal March 26, 2021 19:36
Comment thread adflow/pyADflow.py Resolved
Comment thread adflow/pyADflow_C.py Resolved
Comment thread adflow/pyADflow.py Resolved
@ewu63

ewu63 commented Mar 26, 2021

Copy link
Copy Markdown
Collaborator

That was fast! Do you want to add a ignore-revs file as we did for other repos?

ewu63
ewu63 previously approved these changes Mar 26, 2021
@anilyil

anilyil commented Mar 27, 2021

Copy link
Copy Markdown
Contributor

The changes look good, I dont know what more I can add here because all tests pass. @sseraj dont forget to bump the version number. Are there specific things you want me to look at?

@sseraj

sseraj commented Mar 27, 2021

Copy link
Copy Markdown
Collaborator Author

The changes look good, I dont know what more I can add here because all tests pass. @sseraj dont forget to bump the version number. Are there specific things you want me to look at?

The linting changes are really the only part I wanted a review of, in case I broke something not covered by the tests. If those look fine to you, then I think this is good to merge.

@anilyil anilyil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a look over the linting changes, and they look good to me. Thanks for working on this!

@anilyil
anilyil requested a review from ewu63 March 27, 2021 20:09
@ewu63
ewu63 merged commit cd66e9a into mdolab:master Mar 27, 2021
@ewu63

ewu63 commented Mar 27, 2021

Copy link
Copy Markdown
Collaborator

Don't forget to make a release @sseraj. Thanks for working on this!

@sseraj
sseraj deleted the format-lint branch March 27, 2021 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Format the code

3 participants