Repository navigation
Formatting and linting - #135
Conversation
|
That was fast! Do you want to add a |
|
The changes look good, I dont know what more I can add here because all tests pass. @sseraj dont forget to bump the version number. Are there specific things you want me to look at? |
The linting changes are really the only part I wanted a review of, in case I broke something not covered by the tests. If those look fine to you, then I think this is good to merge. |
anilyil
left a comment
There was a problem hiding this comment.
I took a look over the linting changes, and they look good to me. Thanks for working on this!
|
Don't forget to make a release @sseraj. Thanks for working on this! |
Purpose
Closes #98
Please review the linting changes carefully and comment if it's unclear why I made a certain change.
For flake8, I ignored
The latter two are extremely outdated and should probably be removed from the repo. I can remove them in this PR or we can address that later. Similarly, we may also want to remove pyDynamicPerformance.py and pyPerformanceClass.py.
Type of change
What types of change is it?
Select the appropriate type(s) that describe this PR
Testing
Explain the steps needed to test the new code to verify that it does indeed address the issue and produce the expected behavior.
Checklist
Put an
xin the boxes that apply.flake8andblackto make sure the code adheres to PEP-8 and is consistently formatted