Skip to content

self.comm is now set in BaseSolver - #101

Merged
ewu63 merged 4 commits into
mdolab:masterfrom
eirikurj:fix-comm
Jan 7, 2021
Merged

ewu63 merged 4 commits into
mdolab:masterfrom
eirikurj:fix-comm

Conversation

@eirikurj

@eirikurj eirikurj commented Jan 7, 2021

Copy link
Copy Markdown
Collaborator

Purpose

With recent addition of self.comm to BaseSolver in baseclasses (see mdolab/baseclasses#29) self.comm will is overwritten.
However, PR mdolab/baseclasses#30 now adds self.comm as an argument to BaseSolver making it clear to the user where self.comm is set and less error-prone.
This PR adjusts the code to the above changes.

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Checklist

Put an x in the boxes that apply.

  • I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@eirikurj
eirikurj requested a review from a team as a code owner January 7, 2021 12:25
@eirikurj
eirikurj requested review from anilyil and joanibal January 7, 2021 12:25
ewu63
ewu63 previously approved these changes Jan 7, 2021
sseraj
sseraj previously approved these changes Jan 7, 2021
ewu63
ewu63 previously approved these changes Jan 7, 2021
joanibal
joanibal previously approved these changes Jan 7, 2021
@eirikurj
eirikurj dismissed stale reviews from joanibal, ewu63, and sseraj via db95f8b January 7, 2021 22:34
@ewu63
ewu63 merged commit 836b203 into mdolab:master Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants