Repository navigation
self.comm is now set in BaseSolver - #101
Merged
Merged
Conversation
ewu63
previously approved these changes
Jan 7, 2021
sseraj
previously approved these changes
Jan 7, 2021
ewu63
previously approved these changes
Jan 7, 2021
joanibal
previously approved these changes
Jan 7, 2021
ewu63
approved these changes
Jan 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
With recent addition of self.comm to BaseSolver in baseclasses (see mdolab/baseclasses#29) self.comm will is overwritten.
However, PR mdolab/baseclasses#30 now adds self.comm as an argument to BaseSolver making it clear to the user where self.comm is set and less error-prone.
This PR adjusts the code to the above changes.
Type of change
What types of change is it?
Select the appropriate type(s) that describe this PR
Checklist
Put an
xin the boxes that apply.flake8andblackto make sure the code adheres to PEP-8 and is consistently formatted